Remove custom-metric APIServer code.#8318
Conversation
knative-prow-robot
added
the
do-not-merge/hold
knative-prow-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markusthoemmes The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
knative-prow-robot
requested review from
JRBANCEL,
grantr,
julz,
steuhs,
taragu,
vagababov,
yanweiguo and
yt3liu
knative-prow-robot
left a comment
knative-prow-robot
left a comment
There was a problem hiding this comment.
@markusthoemmes: 0 warnings.
Details
In response to this:
Fixes #8164
Proposed Changes
In accordance to our release principles, a deprecation notice is not necessary here since this is an alpha feature. It's been verified with every Knative vendor that this feature is not shipped in any productized version of Knative, neither has there been any proof that any customer, be it OSS or product, is actively using this.
/hold
Holding until having proper signoff by the Autoscaling WG and maybe also ToC.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
knative-prow-robot
added
the
area/test-and-release
markusthoemmes
force-pushed
the
remove-custom-metrics
branch
from
334e287 to
8fa3d3a
Compare
|
/unhold Time's up. We haven't gotten any indication of usage. |
knative-prow-robot
removed
the
do-not-merge/hold
|
The following is the coverage report on the affected files.
|
|
\o/ |
6 participants
Fixes #8164
Proposed Changes
In accordance to our release principles, a deprecation notice is not necessary here since this is an alpha feature. It's been verified with every Knative vendor that this feature is not shipped in any productized version of Knative, neither has there been any proof that any customer, be it OSS or product, is actively using this.
/hold
Holding until having proper signoff by the Autoscaling WG and maybe also ToC.