Skip to content

Performance improvements in QP in probing mode#8149

Merged
knative-prow-robot merged 3 commits intoknative:masterfrom
vagababov:20200601-qp-imp
Jun 1, 2020
Merged

Performance improvements in QP in probing mode#8149
knative-prow-robot merged 3 commits intoknative:masterfrom
vagababov:20200601-qp-imp

Conversation

@vagababov
Copy link
Contributor

  • reuse the http requests, they are immutable
  • parse much smaller subset of config

/assign @mattmoor @julz
For #8147

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 1, 2020
@knative-prow-robot knative-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/networking approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 1, 2020
@vagababov
Copy link
Contributor Author

In my tests, this dropped the idle to ~36m

@vagababov
Copy link
Contributor Author

removed the extraneous files

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vagababov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-test-reporter-robot

The following jobs failed:

Test name Triggers Retries
pull-knative-serving-unit-tests 0/3

Failed non-flaky tests preventing automatic retry of pull-knative-serving-unit-tests:

cmd/queue.[build failed]

@vagababov
Copy link
Contributor Author

Meh, I wonder why did the tests pass locally :|

@julz
Copy link
Contributor

julz commented Jun 1, 2020

/lgtm

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2020
@knative-prow-robot knative-prow-robot merged commit 556e8ce into knative:master Jun 1, 2020
@vagababov vagababov deleted the 20200601-qp-imp branch June 23, 2020 23:19
@julz julz mentioned this pull request Jul 23, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/autoscale area/networking cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants