Send namespace header in MT components#3184
Merged
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom Jun 29, 2023
Merged
Send namespace header in MT components#3184knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
knative-prow[bot] merged 1 commit intoknative-extensions:mainfrom
Conversation
When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] KafkaSource, Kafka Broker, and KafkaChannel Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
knative-prow
Bot
added
size/XS
Codecov Report
@@ Coverage Diff @@
## main #3184 +/- ##
=============================================
- Coverage 80.14% 63.51% -16.64%
Complexity 757 757
=============================================
Files 77 167 +90
Lines 2670 11661 +8991
Branches 239 239
=============================================
+ Hits 2140 7407 +5267
- Misses 388 3701 +3313
- Partials 142 553 +411
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
Author
Member
Author
|
/test channel-integration-tests-ssl |
matzew
reviewed
Jun 29, 2023
| .timeout(this.consumerVerticleContext.getEgressConfig().getTimeout() <= 0 ? DEFAULT_TIMEOUT_MS : this.consumerVerticleContext.getEgressConfig().getTimeout()) | ||
| .putHeader("Prefer", "reply")) | ||
| .putHeader("Prefer", "reply") | ||
| .putHeader("Kn-Namespace", this.consumerVerticleContext.getEgress().getReference().getNamespace()) |
Contributor
There was a problem hiding this comment.
so we set it all the time.
but benefit from it on the "mesh case", since we can use that for filtering/tweaking ?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: matzew, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
added a commit
to pierDipi/eventing-kafka-broker
that referenced
this pull request
Jul 20, 2023
When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] KafkaSource, Kafka Broker, and KafkaChannel Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Jul 20, 2023
When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] KafkaSource, Kafka Broker, and KafkaChannel Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/eventing-kafka-broker
that referenced
this pull request
Jul 20, 2023
When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] KafkaSource, Kafka Broker, and KafkaChannel Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
openshift-merge-robot
pushed a commit
to openshift-knative/eventing-kafka-broker
that referenced
this pull request
Jul 21, 2023
When running MT components [1] in mesh mode with Istio, we lose the ability to define fine grained policies since we don't know the resource namespace that originated such request, therefore, by having a `Kn-Namespace` header, in mesh mode, users case define fine-grained policies and isolate namespaces. [1] KafkaSource, Kafka Broker, and KafkaChannel Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com> Co-authored-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running MT components [1] in mesh mode with Istio,
we lose the ability to define fine grained policies since we
don't know the resource namespace that originated such
request, therefore, by having a
Kn-Namespaceheader,in mesh mode, users case define fine-grained policies and
isolate namespaces.
[1] KafkaSource, Kafka Broker, and KafkaChannel
Related to knative/eventing#7048