Skip to content

[release-v1.9] Send namespace header in MT components (#3184)#750

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.9from
pierDipi:cp-fe4652b82-v1.9
Jul 20, 2023
Merged

[release-v1.9] Send namespace header in MT components (#3184)#750
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.9from
pierDipi:cp-fe4652b82-v1.9

Conversation

@pierDipi
Copy link
Copy Markdown
Member

When running MT components [1] in mesh mode with Istio,
we lose the ability to define fine grained policies since we
don't know the resource namespace that originated such
request, therefore, by having a `Kn-Namespace` header,
in mesh mode, users case define fine-grained policies and
isolate namespaces.

[1] KafkaSource, Kafka Broker, and KafkaChannel

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Copy Markdown
Member Author

/cherry-pick release-v1.10

@openshift-cherrypick-robot
Copy link
Copy Markdown

@pierDipi: once the present PR merges, I will cherry-pick it on top of release-v1.10 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from creydr and matzew July 20, 2023 10:37
@pierDipi
Copy link
Copy Markdown
Member Author

/assign @creydr @matzew

@pierDipi
Copy link
Copy Markdown
Member Author

/test 412-test-reconciler-aws-ocp-412

Copy link
Copy Markdown
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jul 20, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-cherrypick-robot
Copy link
Copy Markdown

@pierDipi: new pull request created: #752

Details

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants