Skip to content

[release-v1.10] Send namespace header in MT components (#3184)#752

Merged
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.10from
openshift-cherrypick-robot:cherry-pick-750-to-release-v1.10
Jul 21, 2023
Merged

[release-v1.10] Send namespace header in MT components (#3184)#752
openshift-merge-robot merged 1 commit into
openshift-knative:release-v1.10from
openshift-cherrypick-robot:cherry-pick-750-to-release-v1.10

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #750

/assign pierDipi

When running MT components [1] in mesh mode with Istio,
we lose the ability to define fine grained policies since we
don't know the resource namespace that originated such
request, therefore, by having a `Kn-Namespace` header,
in mesh mode, users case define fine-grained policies and
isolate namespaces.

[1] KafkaSource, Kafka Broker, and KafkaChannel

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Copy link
Copy Markdown
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm label Jul 20, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 4875104 and 2 for PR HEAD 354c5e5 in total

@pierDipi
Copy link
Copy Markdown
Member

/retest

@openshift-merge-robot openshift-merge-robot merged commit e198bf0 into openshift-knative:release-v1.10 Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants