Skip to content

Send namespace header in MT components #3184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
knative-prow merged 1 commit into from
Jun 29, 2023
Merged

Send namespace header in MT components #3184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...ava/dev/knative/eventing/kafka/broker/dispatcher/impl/http/WebClientCloudEventSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,7 +176,9 @@ private Future<?> send(final CloudEvent event, final Promise<HttpResponse<Buffer
return VertxMessageFactory
.createWriter(client.postAbs(target)
.timeout(this.consumerVerticleContext.getEgressConfig().getTimeout() <= 0 ? DEFAULT_TIMEOUT_MS : this.consumerVerticleContext.getEgressConfig().getTimeout())
.putHeader("Prefer", "reply"))
.putHeader("Prefer", "reply")
.putHeader("Kn-Namespace", this.consumerVerticleContext.getEgress().getReference().getNamespace())

@matzew matzew Jun 29, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we set it all the time.

but benefit from it on the "mesh case", since we can use that for filtering/tweaking ?

@pierDipi pierDipi Jun 29, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

)
.writeBinary(event)
.onFailure(ex -> {
logError(event, ex);
Expand Down