[pull] master from openshift:master - #44
Merged
Merged
Conversation
* loglevel Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * Remove panic and fatal * resolves https://github.com/openshift/oadp-operator/pull/588/files#r823051753, https://github.com/openshift/oadp-operator/pull/588/files#r823050949 * refactor err * panic fatal removed from error message * resolves #588 (comment) * make bundle to update crd * Copy ParseLevel function, use hardcoded error str
* update docs/examples, use ci templates and mysql * Previously we had duplicate templates for mssql * Templates used in docs/examples should be part of regular ci to ensure they always work for the community * using softlinks from tests/e2e to docs/examples/ * update the docs s/mssql/mysql Closes-Issue: #622 * update symlinks to be a relative path
…sed in Config - Fixes CI (#637) * Changing Credentials Mount Name for BSL for GCP * Fix DefaultPlugin for credentialsFile
* Bring back `component: velero` label, fix OADP-452 * fix component:server on deployment, unit test update
…ges: false (#607) * Don't getProviderSecret when noDefaultBackupLocation flag set Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com> * add check that when NoDefaultBackupLocation is set, dpa.Spec.BackupImages is false Use BackupImages functions when checking conditions * fix test case
* Adding azure parameters * Adding Openshift CI params * Update Test Suite and Helpers * Adding cred ref * Adding cred ref * Changing azure oadp cred dir to tmp * Fixing duplicate error * Removing OpenShift CI * Changing test instance name * Changing the AWS BSL Profile to default * Changing BslMountPath variable in registry controller
* Adding function to verify BackUp / Restore data * Adding verification for mysql * Adding timeout / retry function * Changing VerifyBackupRestoreData fn name
…wait for CSI snapshot to be ready, IsDCReady wait for builds, azure-rg (#654) * Print namespace events when installing apps fail This is useful for debugging pods not starting up or stuck. Example event that would come up before #650 is merged ``` Event: Error: couldn't find key access_key in Secret openshift-adp/oadp-ts-example-velero-1-aws-registry-secret, Src: kubelet, Reason: Failed ``` * use metav1 Time * format * Get events after time * add sort and count to event * Update lastInstallTime and lastInstallApplicationNamespace for app restore * Add restic restore workaround to e2e. Add opts for CreateRestoreFromBackup * Implementing DC workaround in e2e https://github.com/openshift/oadp-operator/blob/master/docs/TROUBLESHOOTING.md#deployconfig * Handle IsNotRegisteredError * different restore name for workaround * try add templatev1 to scheme * updateLastInstallingNamespace func * E2E Wait for snapshot to be ready for CSI B/R case Fix ``` Event: failed to provision volume with StorageClass "gp2-csi": error getting handle for DataSource Type VolumeSnapshot by Name velero-mysql-l5sz5: snapshot velero-mysql-l5sz5 is not Ready, Type: Warning, Count: 10, Src: {PersistentVolumeClaim mysql-persistent mysql 72d98c8-10ff-4a32-a319-88bed69e1227 v1 34225 }, Reason: ProvisioningFailed ``` seen at https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_oadp-operator/654/pull-ci-openshift-oadp-operator-master-4.9-operator-e2e-aws/1520234660829859840#1:build-log.txt%3A375 * addToScheme volumesnapshotv1 * check volumesnapshots by label * Describe backup and restore in backup restore suite test * format * fix make test, install.AllCRDs param removal * log so we know we are waiting on volumesnapshot * Wait for builds before considering app ready * move B/R describe to ginkgowriter * add builds ready check to after restic DC restore workaround first step * IsVolumeSnapshotsReady ->AreVolumeSnapshotsReady * use correct restore name to check for done * Use GinkgoWriter for describe * fix getVeleroPods labels * B/R logs request via downloadrequest * Check cluster version skip before building dpa * Azure resource group (#45) * fix awk for azure resource group * newline proof awk for resourcegroup * remove unused commented codes * break loop after found DC availability condition * rebase reverted go.mod velero update * make test go fmt * use log.Printf
…E2E changes (#652) * Replace carriage return when getting provider secrets for registry Co-authored-by: GitHub Co-pilot <idkwhatemailgithubcopilotuses@github.com> * add tests * replaceCarriageReturn unit test * Registry credentials can use other secret names Co-authored-by: GitHub Co-pilot <idkwhatemailgithubcopilotuses@github.com>
* blog init * update * address #592 (review) * resolves #592 (review) * resolves #592 (review) * update * check previous message * label update * remove unused png * the shall not pass * team breakfast is due at Red Hat Cafe * remove unused comments so table of content autoupdates * Clear up sentences * rm old txt reference * clarify fields to update dpa template * cleanup Gathering information from Object Bucket * grammar update * Refer user to ODF deployment docs, verify ODF * remove redundant step * add bucket name/host query * definitions * query secret * Rearrange bucket info gathering * bucket name, bucket host commands prefix title * bucket name/host cleanup * Rearrange Modifying VolumeSnapshotClass, add cli * the teleport * backup typo * cli bucket name fix * decode secret * Table of Content*s* * Update oadp-blog.md
* IDE launch template. e2e flags from environment. * Add a few more pre-reqs text for launching main.go * Add OPENSHIFT_CI * rm OPENSHIFT_CI
…hanges to the latest version ..." (#653) * CreateOrUpdate call CreateOrUpdateWithRetries with 3 default retries when err is conflict. * Avoid stack growth using for loop * fix retries counting error * err reference typo, rearrange condition
* fix OADP-487 * rebase and fix unit tests
* OADP 486 - Update velero service account permissions * Add back velero-privileged
* deploy-olm make target uses tmp to avoid modifying repo * rm before mkdir, move comments away from commands. * Use expanded variable DEPLOY_TMP * add cache to .gitignore
* CLUSTER_TYPE auto discovery * remove else * address https://github.com/openshift/oadp-operator/pull/664/files#r864759600 feedback
kaovilai
added a commit
that referenced
this pull request
Aug 5, 2026
… to plugin PR #44 VirtualMachineBackupTracker deletion can leave a VirtualMachineBackup's backup.kubevirt.io/vmbackup-protection finalizer stuck (kubevirt#18724), blocking namespace deletion forever in the incremental-sequence and restore specs. IsNamespaceDeletedClearingStuckVMBFinalizers works around it by clearing stale finalizers on every poll; safe to remove once that kubevirt issue is fixed. Also fixes a real race: VirtualMachineBackup is ephemeral and can be deleted by virt-controller before the overall backup finishes uploading, so checking its status after backup completion (as before) could find nothing. runKubevirtDMBackup now takes an onDataUploadFound callback invoked as soon as the DataUpload appears, letting the incremental- sequence spec check VMB status while it still exists. migtools/kubevirt-datamover-plugin#41 merged; the e2e image override now points at #44 instead, which fixes a still-open bug where restored PVCs come back with stale spec.volumeName/status, causing the datamover controller to reject them as "already bound". Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added a commit
that referenced
this pull request
Aug 6, 2026
…sk resume gating Both findings verified against actual code by kdm-controller/kdm-plugin peer agents rather than guessed: - VMB is orphaned on genuine Failed (non-canceled) DataUpload; issue #12 closed but only delivered the success-path half. - VM RIA resume gating counts only currently-discovered DataDownloads, not the VM's full expected volume count; accepted single-disk-only scope boundary for #124/#44, dormant since multi-disk restore itself is blocked on controller#73 phase4. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added a commit
that referenced
this pull request
Aug 6, 2026
…tnote Backup/restore design sections (VirtualMachine RIA plugin, DataDownload reconciler) previously only described pre-#124/#44 behavior. Add the halt-at-restore/resume-on-siblings-complete mechanism to the actual design prose, including the multi-disk scope boundary, and trim the now-duplicated description out of the Implementation status section. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
kaovilai
added a commit
that referenced
this pull request
Aug 13, 2026
Both fixes are now merged upstream: migtools/kubevirt-datamover-plugin#41 and #44 (VM-eager-start race, restore RIAs), and migtools/kubevirt-datamover-controller#124 (issue #73 phase 3 DataDownload controller). The suite now exercises the default images per the TODO this override block left for itself. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )