Skip to content

Update upstream kubevirt tag in manager deployment env, preserve #611 changes in config - #615

Merged
kaovilai merged 2 commits into
openshift:masterfrom
kaovilai:bundleconfig
Apr 8, 2022
Merged

kaovilai merged 2 commits into
openshift:masterfrom
kaovilai:bundleconfig

Conversation

@kaovilai

@kaovilai kaovilai commented Mar 25, 2022

Copy link
Copy Markdown
Member

preserve OADP-380 in config

@kaovilai

Copy link
Copy Markdown
Member Author

/retest

3 similar comments
@kaovilai

Copy link
Copy Markdown
Member Author

/retest

@kaovilai

Copy link
Copy Markdown
Member Author

/retest

@kaovilai

Copy link
Copy Markdown
Member Author

/retest

operatorframework.io/suggested-namespace: openshift-adp
operators.openshift.io/infrastructure-features: '["Disconnected"]'
operators.openshift.io/valid-subscription: '["OpenShift Container Platform", "OpenShift
Platform Plus"]'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why new line?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because

operator-sdk generate kustomize manifests -q

automatically caused it to truncate the line.

@kaovilai kaovilai changed the title Preserve #611 bundle changes in config manifests Update upstream kubevirt tag, preserve #611 changes in config Apr 7, 2022
@kaovilai kaovilai changed the title Update upstream kubevirt tag, preserve #611 changes in config Update upstream kubevirt tag in manager deployment env, preserve #611 changes in config Apr 7, 2022

@rayfordj rayfordj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 7, 2022
@openshift-ci

openshift-ci Bot commented Apr 7, 2022

Copy link
Copy Markdown

@kaovilai: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai
kaovilai merged commit 1d64f78 into openshift:master Apr 8, 2022
kaovilai added a commit to kaovilai/oadp-operator that referenced this pull request May 6, 2022
…shift#611 changes in config (openshift#615)

* Preserve openshift#611 bundle changes in config manifests

* prefix `v` to kubevirt tag
kaovilai added a commit to kaovilai/oadp-operator that referenced this pull request May 6, 2022
…shift#611 changes in config (openshift#615)

* Preserve openshift#611 bundle changes in config manifests

* prefix `v` to kubevirt tag
dymurray pushed a commit that referenced this pull request May 9, 2022
…changes in config (#615) (#675)

* Preserve #611 bundle changes in config manifests

* prefix `v` to kubevirt tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants