Skip to content

[release-1.27] Backports for 2024-02 release cycle#9463

Merged
brandond merged 10 commits intok3s-io:release-1.27from
brandond:2024-02-backports_release-1.27
Feb 10, 2024
Merged

[release-1.27] Backports for 2024-02 release cycle#9463
brandond merged 10 commits intok3s-io:release-1.27from
brandond:2024-02-backports_release-1.27

Conversation

@brandond
Copy link
Copy Markdown
Member

@brandond brandond commented Feb 9, 2024

brandond and others added 10 commits February 9, 2024 23:40
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 4005600)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
The reconcile may run before the kubelet has created the node object; retry until it succeeds

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 82e3c32)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 6ec1926)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Ref: rancher/plugins@v1.3.0-k3s1...v1.4.0-k3s2

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 77ba990)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
The nodes controller was reading from the configmaps cache, but doesn't add any handlers, so if no other controller added configmap handlers, the cache would remain empty.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 888f866)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit 8224a3a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Oleg Matskiv <oleg.matskiv@gmail.com>
(cherry picked from commit e3b237f)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Edgar Lee <edgarhinshunlee@gmail.com>
(cherry picked from commit 14c6c63)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Edgar Lee <edgarhinshunlee@gmail.com>
(cherry picked from commit 0ac4c6a)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
(cherry picked from commit de82584)
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
@brandond brandond requested a review from a team as a code owner February 9, 2024 23:45
@codecov
Copy link
Copy Markdown

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 38 lines in your changes are missing coverage. Please review.

Comparison is base (99e5e6c) 49.40% compared to head (c53cb2a) 45.92%.

Files Patch % Lines
pkg/rootless/mounts.go 0.00% 14 Missing ⚠️
pkg/cli/etcdsnapshot/etcd_snapshot.go 72.72% 6 Missing and 3 partials ⚠️
pkg/etcd/snapshot.go 14.28% 4 Missing and 2 partials ⚠️
pkg/etcd/etcd.go 90.32% 2 Missing and 1 partial ⚠️
pkg/node/controller.go 40.00% 2 Missing and 1 partial ⚠️
pkg/server/router.go 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-1.27    #9463      +/-   ##
================================================
- Coverage         49.40%   45.92%   -3.49%     
================================================
  Files               154      154              
  Lines             16509    16572      +63     
================================================
- Hits               8157     7610     -547     
- Misses             7069     7718     +649     
+ Partials           1283     1244      -39     
Flag Coverage Δ
e2etests ?
inttests 42.79% <63.10%> (+0.01%) ⬆️
unittests 15.12% <18.64%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brandond brandond merged commit f6303cf into k3s-io:release-1.27 Feb 10, 2024
@brandond brandond deleted the 2024-02-backports_release-1.27 branch June 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants