Bump kine and set NotifyInterval to what the apiserver expects#9349
Merged
brandond merged 1 commit intok3s-io:masterfrom Feb 9, 2024
Merged
Bump kine and set NotifyInterval to what the apiserver expects#9349brandond merged 1 commit intok3s-io:masterfrom
brandond merged 1 commit intok3s-io:masterfrom
Conversation
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9349 +/- ##
==========================================
- Coverage 45.69% 41.05% -4.64%
==========================================
Files 154 154
Lines 16623 16628 +5
==========================================
- Hits 7596 6827 -769
- Misses 7814 8646 +832
+ Partials 1213 1155 -58
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vitorsavian
approved these changes
Feb 5, 2024
dereknola
approved these changes
Feb 9, 2024
galal-hussein
approved these changes
Feb 9, 2024
This was referenced Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Bump kine for WatchProgressRequest support and set NotifyInterval to what the apiserver expects
Note upstream says they always test with the notification interval set to 5 seconds. The flag is apparently GA in 3.5 despite being named
experimental.kubernetes/kubernetes#122805 (comment)
Types of Changes
version bump
upstream compat
Verification
Normal release tests
Testing
Linked Issues
User-Facing Change
Further Comments