Fix issue with coredns node hosts controller#9354
Merged
brandond merged 1 commit intok3s-io:masterfrom Feb 7, 2024
Merged
Conversation
The nodes controller was reading from the configmaps cache, but doesn't add any handlers, so if no other controller added configmap handlers, the cache would remain empty. Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
brandond
force-pushed
the
fix-coredns-node-controller-race
branch
from
1ecf09c to
3d76699
Compare
dereknola
approved these changes
Feb 5, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9354 +/- ##
===========================================
- Coverage 45.69% 14.88% -30.81%
===========================================
Files 154 154
Lines 16623 16625 +2
===========================================
- Hits 7596 2475 -5121
- Misses 7814 13833 +6019
+ Partials 1213 317 -896
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
manuelbuil
approved these changes
Feb 6, 2024
This was referenced Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix issue with coredns node hosts controller
The nodes controller was reading from the configmaps cache, but doesn't add any handlers, so if no other controller (the helm controller, for example) adds configmap handlers, the cache would remain empty.
We made the embedded helm-controller disableable a while back, but didn't test the secondary effects that disabling might have on other components that are relying on the caches being populated by the configmap and secret caches that the helm controller fills.
Types of Changes
bugfix
Verification
see linked issue
Testing
Linked Issues
User-Facing Change
Further Comments