Merged
Conversation
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
The reconcile may run before the kubelet has created the node object; retry until it succeeds Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #9318 +/- ##
==========================================
- Coverage 49.07% 40.56% -8.51%
==========================================
Files 154 154
Lines 16416 16558 +142
==========================================
- Hits 8056 6717 -1339
- Misses 7090 8695 +1605
+ Partials 1270 1146 -124
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dereknola
approved these changes
Feb 2, 2024
vitorsavian
approved these changes
Feb 6, 2024
This was referenced Feb 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fix snapshot reconcile retry
The reconcile may run before the kubelet has created the node object; retry until it succeeds
Types of Changes
bugfix
Verification
See linked issues
Testing
Linked Issues
User-Facing Change
Further Comments