Parse preprocess rules from component routers #8986

alexva24 · 2016-01-26T14:25:52Z

The aim of this PR is providing possibility to execute custom component's parse preprocess rules instead develop onAfterInitialise plugin.

For testing you should create parsepreprocess method on router of any installed components. The method will be executed on 593 line /libraries/cms/router/router.php

the parse preprocess rules added from component's routers

The getComponents method loads all installed components

CS fox for #8801

CS fIx

wojsmol · 2016-01-26T16:14:02Z

Replaces #8801

anibalsanchez · 2016-02-05T21:11:43Z

I have tested this item ✅ successfully on 27802e7

Test OK.

Tested in com_content/router.php

class ContentRouter extends JComponentRouterBase
{
public function parsepreprocess() {
die;
}

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8986.}

roland-d · 2016-08-01T19:22:21Z

libraries/cms/router/site.php


+		// Set the parsepreprocess components methods
+		$components = JComponentHelper::getComponents();
+		foreach ($components as $component)


Codestyle dictactes we need an empty line before the foreach.

Curiensol · 2016-08-02T08:45:31Z

I have tested this item ✅ successfully on 27802e7

Tested in components\com_users\router.php @icampus Pizza, Bugs & Fun

class UsersRouter extends JComponentRouterBase //test
{
public function parsepreprocess() {
echo "Working!";

}

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8986.}

brianteeman · 2016-08-02T08:53:00Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8986.}

rdeutz · 2016-08-14T15:26:33Z

@alexva24 cloud you fix code style and since tag, please.

zero-24 · 2016-08-14T15:36:55Z

@rdeutz it is prepared here: https://github.com/joomla/joomla-cms/compare/staging...zero-24:alexva24?expand=1 you can merge than i open the CS / @SInCE version PR for you to merge.

fix cs and merge staging

zero-24 · 2016-08-15T09:55:33Z

Thanks @alexva24 and @rdeutz

* re-arrayhelper-min: (2467 commits) Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. remove platform include (joomla#11615) [GitHub Templates] Make headings bigger (joomla#11607) [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503) Small review on docs & code structure in JModelLegacy library classes (joomla#11057) Obviously, this should be an array. (joomla#11610) Don't manually import JPlatform anymore (joomla#10841) Parse preprocess rules from component routers (joomla#8986) Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606) Add missing clean line after joomla#9277 (joomla#11605) Deprecate the _PROFILER global var (joomla#10845) Spelling errors (joomla#11604) Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603) Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511) [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593) [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502) $result-variable-undefined-given-default-value (joomla#9277) com_banners use exceptions. and not allowed is a 403 (joomla#11418) Frontend & plugins using the autoloader (joomla#10882) New version of PR 6788 (JText::_() Optimizations) (joomla#11235) ...

* the parse preprocess rules added the parse preprocess rules added from component's routers * getComponents method added The getComponents method loads all installed components * CS fIx CS fox for joomla#8801 * CS for helper.php * cs & deploy version

vinespie · 2016-10-19T08:43:43Z

I think there is a problem with using "JComponentHelper::getComponents()".
Static method "load" in class "JComponentHelper" get all components even those who discover.

ghost · 2016-10-22T23:26:27Z

Could someone please correct the Milestone 3.7.0? This PR was merged in Joomla 3.6.3. Thank you!

tonypartridge · 2016-10-25T15:31:10Z

With xmap installed and on Joomla! 3.6.2 works fine, Joomla! 3.6.4 we get

syntax error, unexpected '$items' (T_VARIABLE)

Because this change was pulled in on 3.6.3. Whilst I appreciate it's likely bad outdated coding in xmap. A lot of sites use xmap and we will now be taking them down with this change :-/

Many thanks
Tony

zero-24 · 2016-10-25T15:39:57Z

syntax error, unexpected '$items' (T_VARIABLE)

where? is that line?

tonypartridge · 2016-10-25T15:48:29Z

Sorry! Error reports It was caused at line 123 of
/libraries/cms/router/site.php

I'm just downloading an older backup to try and produce a server to replicate it on since the site was live I just removed xmap completely.

zero-24 · 2016-10-25T15:50:11Z

looks like an old or hacked version see: https://github.com/joomla/joomla-cms/blob/3.6.4/libraries/cms/router/site.php#L123

tonypartridge · 2016-10-25T15:52:41Z

No, that is the same file. I replaced the parse function completely with the version from 3.6.2 to debug it and did an output of the option on the foreach loop. noticing it produced a fatal after com_xamp was loaded with the 3.6.3 site.php router file.

I'll debug further and let you know the outcome.

zero-24 · 2016-10-25T15:54:51Z

Please open than a new bug report with all needed information. Commenting on a closed / merged PR get missed fast. ;)

brianteeman · 2016-10-25T18:41:31Z

Isn't xmap abandoned now?

tonypartridge · 2016-10-25T18:45:07Z

Yep, but a normal user wouldn't have a clue or know anything about their xmap version since it's not shown in the updater if it's of a certain version.

The fact the site works fine on 3.6.2 but the 3.6.4 update breaks the site is my point, an incremental version is breaking things regardless of how it should be done. Anyway I'll debug and open a new issue.

Hackwar · 2018-08-23T19:12:13Z

Sorry to say this, but this change is pretty horrible. It loads all components, regardless of them even having a frontend part, and then does lots of checks, only to fail for most components and then creating legacy routers for those. And that is why the site of a customer of mine instantiates 57 router objects in the frontend and sites with xmap fail after this "feature". And all of that because one dev didn't want to create a plugin for his special parseing code. 😠

brianteeman · 2018-08-23T19:19:00Z

Please open than a new bug report with all needed information. Commenting on a closed / merged PR get missed fast

Hackwar · 2018-08-26T19:35:19Z

I know that, but since this has been released, there is nothing that we really can do. This is now out in the open and we have to wait for Joomla 4.0 to fix this. Coincidentally, this did not survive the changes for the 4.0 router.

So, an unsolvable bug for 3.x that has been fixed in 4.0. I just wanted to document that this is a stupid idea in the hopes that future generations stumble upon this and make wiser decisions.

Aleksey Vaganov and others added 5 commits December 28, 2015 11:23

the parse preprocess rules added

956bc40

the parse preprocess rules added from component's routers

getComponents method added

5122b27

The getComponents method loads all installed components

CS fIx

d6f021d

CS fox for #8801

CS for helper.php

41c5684

Merge pull request #1 from wojsmol/patch-7

27802e7

CS fIx

joomla-cms-bot added the PR-staging label Jan 26, 2016

wojsmol mentioned this pull request Jan 26, 2016

parse preprocess rules from component routers #8801

Closed

roland-d reviewed Aug 1, 2016
View reviewed changes

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 2, 2016

rdeutz added this to the Joomla 3.7.0 milestone Aug 14, 2016

zero-24 added 2 commits August 14, 2016 17:29

Merge branch 'staging' of github.com:/alexva24/joomla-cms into alexva24

78089d8

cs & deploy version

59a1e55

Merge pull request #3 from zero-24/alexva24

4e721cf

fix cs and merge staging

rdeutz merged commit 9df98b7 into joomla:staging Aug 15, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2016

This was referenced Oct 19, 2016

[/cms/component/helper] Exclude components in discover state from list vinespie/joomla-cms#2

Merged

[/cms/component/helper] Exclude components in discover state from list #12469

Closed

mahagr mentioned this pull request Oct 21, 2016

Joomla 3.6.3 breaks many sites due to badly written 3rd party component routers #12499

Closed

zero-24 modified the milestones: Joomla 3.6.3, Joomla 3.7.0 Oct 22, 2016

mahagr mentioned this pull request Oct 24, 2016

Home outline loses it's ability to render after updating to Joomla 3.6.3 gantry/gantry5#1634

Closed

Hackwar mentioned this pull request Aug 23, 2018

[4.0] Introduce router service #20339

Merged

Uh oh!

Parse preprocess rules from component routers #8986

Parse preprocess rules from component routers #8986

Uh oh!

Conversation

alexva24 commented Jan 26, 2016 • edited by brianteeman Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wojsmol commented Jan 26, 2016

Uh oh!

anibalsanchez commented Feb 5, 2016

Uh oh!

roland-d Aug 1, 2016

Choose a reason for hiding this comment

Uh oh!

Curiensol commented Aug 2, 2016

Uh oh!

brianteeman commented Aug 2, 2016

Uh oh!

rdeutz commented Aug 14, 2016

Uh oh!

zero-24 commented Aug 14, 2016

Uh oh!

zero-24 commented Aug 15, 2016

Uh oh!

vinespie commented Oct 19, 2016

Uh oh!

ghost commented Oct 22, 2016

Uh oh!

tonypartridge commented Oct 25, 2016

Uh oh!

zero-24 commented Oct 25, 2016

Uh oh!

tonypartridge commented Oct 25, 2016

Uh oh!

zero-24 commented Oct 25, 2016

Uh oh!

tonypartridge commented Oct 25, 2016

Uh oh!

zero-24 commented Oct 25, 2016

Uh oh!

brianteeman commented Oct 25, 2016 via email

Uh oh!

tonypartridge commented Oct 25, 2016

Uh oh!

Hackwar commented Aug 23, 2018

Uh oh!

brianteeman commented Aug 23, 2018

Uh oh!

Hackwar commented Aug 26, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

alexva24 commented Jan 26, 2016 •

edited by brianteeman

Loading