-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) #11593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rdeutz
merged 3 commits into
joomla:staging
from
andrepereiradasilva:poc-exception-plugins
Aug 14, 2016
Merged
[com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) #11593
rdeutz
merged 3 commits into
joomla:staging
from
andrepereiradasilva:poc-exception-plugins
Aug 14, 2016
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
I have tested this item ✅ successfully on This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593. |
Member
|
I have tested this item ✅ successfully on e1253ed This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593. |
|
I have tested this item ✅ successfully on e1253ed This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593. |
Member
|
RTC please This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11593. |
This was referenced Aug 14, 2016
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
Aug 15, 2016
* re-arrayhelper-min: (2467 commits) Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. remove platform include (joomla#11615) [GitHub Templates] Make headings bigger (joomla#11607) [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503) Small review on docs & code structure in JModelLegacy library classes (joomla#11057) Obviously, this should be an array. (joomla#11610) Don't manually import JPlatform anymore (joomla#10841) Parse preprocess rules from component routers (joomla#8986) Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606) Add missing clean line after joomla#9277 (joomla#11605) Deprecate the _PROFILER global var (joomla#10845) Spelling errors (joomla#11604) Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603) Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511) [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593) [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502) $result-variable-undefined-given-default-value (joomla#9277) com_banners use exceptions. and not allowed is a 403 (joomla#11418) Frontend & plugins using the autoloader (joomla#10882) New version of PR 6788 (JText::_() Optimizations) (joomla#11235) ...
ggppdk
pushed a commit
to ggppdk/joomla-cms
that referenced
this pull request
Aug 19, 2016
…eption (instead of a 404 JError) (joomla#11593) * add exception * lowercase * lowercase
roland-d
pushed a commit
to roland-d/joomla-cms
that referenced
this pull request
Sep 11, 2016
…eption (instead of a 404 JError) (joomla#11593) * add exception * lowercase * lowercase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Improvement.
Summary of Changes
Replace com_plugins existing 404 JError for a 403 php exception when the user does not have access to "Access Administration Interface" (core.manage).
Also adds a custom exception
JControllerExceptionNotallowedfor this effect.Before
After
Testing Instructions
When/If merged i can do it for the other components.
thanks @mbabker