-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Add missing clean line after https://github.com/joomla/joomla-cms/pull/9277 #11605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have tested this item ✅ successfully on This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11605. |
|
I have tested this item ✅ successfully on This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11605. |
|
RTC please This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11605. |
|
Travis is still falling on this, I have no idea why. Expecting jenkins failure in a few moments :-) |
|
ah I know why the script was moved in-between |
|
Here we are: http://build.joomla.org/job/cms/5853/ |
This has nothing to do with this change. The build itself is successful. |
|
You are right it is not the change but the circumstances: After you created the PR another got merged and this one moved a script to another place, if I merge your change the move of the file has happened but the code change in the travis.yml not (don't asked me why). So the travis is failing on this PR. The master branch is protected so our jenkins server can only merge PR's into the master branch when travis is on green. To keep a long story short, never ever merge a PR when travis is not on green. |
* re-arrayhelper-min: (2467 commits) Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. remove platform include (joomla#11615) [GitHub Templates] Make headings bigger (joomla#11607) [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503) Small review on docs & code structure in JModelLegacy library classes (joomla#11057) Obviously, this should be an array. (joomla#11610) Don't manually import JPlatform anymore (joomla#10841) Parse preprocess rules from component routers (joomla#8986) Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606) Add missing clean line after joomla#9277 (joomla#11605) Deprecate the _PROFILER global var (joomla#10845) Spelling errors (joomla#11604) Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603) Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511) [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593) [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502) $result-variable-undefined-given-default-value (joomla#9277) com_banners use exceptions. and not allowed is a 403 (joomla#11418) Frontend & plugins using the autoloader (joomla#10882) New version of PR 6788 (JText::_() Optimizations) (joomla#11235) ...
Pull Request for Issue #9277
Summary of Changes
CodeStyle
Testing Instructions
none. On request by @rdeutz after #9277
Documentation Changes Required
none