Skip to content

Conversation

@zero-24
Copy link
Contributor

@zero-24 zero-24 commented Aug 14, 2016

Pull Request for Issue #9277

Summary of Changes

CodeStyle

Testing Instructions

none. On request by @rdeutz after #9277

Documentation Changes Required

none

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on

code review


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11605.

@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11605.

@jeckodevelopment
Copy link
Member

RTC please


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11605.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 14, 2016
@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Aug 14, 2016
@wilsonge wilsonge merged commit b5b2579 into joomla:staging Aug 14, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 14, 2016
@rdeutz
Copy link
Contributor

rdeutz commented Aug 14, 2016

Travis is still falling on this, I have no idea why. Expecting jenkins failure in a few moments :-)

@rdeutz
Copy link
Contributor

rdeutz commented Aug 14, 2016

ah I know why the script was moved in-between

@zero-24 zero-24 deleted the patch-15 branch August 14, 2016 17:25
@rdeutz
Copy link
Contributor

rdeutz commented Aug 14, 2016

Here we are: http://build.joomla.org/job/cms/5853/

@zero-24
Copy link
Contributor Author

zero-24 commented Aug 14, 2016

**Pushing HEAD to branch master at repo projects
 > git --version # timeout=10
 > git -c core.askpass=true push ssh://[email protected]/joomla-projects/joomla-cms.git HEAD:master
Pushing HEAD to branch master at repo origin
 > git -c core.askpass=true push ssh://[email protected]/joomla/joomla-cms.git HEAD:master
ERROR: Failed to push branch master to origin
hudson.plugins.git.GitException: Command "git -c core.askpass=true push ssh://[email protected]/joomla/joomla-cms.git HEAD:master" returned status code 1:
stdout: 
stderr: remote: error: GH006: Protected branch update failed for refs/heads/master.        
remote: error: Required status check "continuous-integration/travis-ci/push" is pending        
To ssh://[email protected]/joomla/joomla-cms.git
 ! [remote rejected] HEAD -> master (protected branch hook declined)
error: failed to push some refs to 'ssh://[email protected]/joomla/joomla-cms.git'

    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1723)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1459)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:63)
    at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$8.execute(CliGitAPIImpl.java:1799)
    at hudson.plugins.git.GitPublisher.perform(GitPublisher.java:331)
    at hudson.tasks.BuildStepMonitor$3.perform(BuildStepMonitor.java:45)
    at hudson.model.AbstractBuild$AbstractBuildExecution.perform(AbstractBuild.java:779)
    at hudson.model.AbstractBuild$AbstractBuildExecution.performAllBuildSteps(AbstractBuild.java:720)
    at hudson.model.Build$BuildExecution.post2(Build.java:185)
    at hudson.model.AbstractBuild$AbstractBuildExecution.post(AbstractBuild.java:665)
    at hudson.model.Run.execute(Run.java:1745)
    at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
    at hudson.model.ResourceController.execute(ResourceController.java:98)
    at hudson.model.Executor.run(Executor.java:404)
Build step 'Git Publisher' marked build as failure
Notifying endpoint 'HTTP:https://developer.joomla.org/glip/jenkins.php'
Finished: FAILURE**

This has nothing to do with this change. The build itself is successful.

@rdeutz
Copy link
Contributor

rdeutz commented Aug 14, 2016

You are right it is not the change but the circumstances: After you created the PR another got merged and this one moved a script to another place, if I merge your change the move of the file has happened but the code change in the travis.yml not (don't asked me why). So the travis is failing on this PR. The master branch is protected so our jenkins server can only merge PR's into the master branch when travis is on green. To keep a long story short, never ever merge a PR when travis is not on green.

izharaazmi added a commit to izharaazmi/joomla-cms that referenced this pull request Aug 15, 2016
* re-arrayhelper-min: (2467 commits)
  Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
  remove platform include (joomla#11615)
  [GitHub Templates] Make headings bigger (joomla#11607)
  [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503)
  Small review on docs & code structure in JModelLegacy library classes (joomla#11057)
  Obviously, this should be an array. (joomla#11610)
  Don't manually import JPlatform anymore (joomla#10841)
  Parse preprocess rules from component routers (joomla#8986)
  Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606)
  Add missing clean line after joomla#9277 (joomla#11605)
  Deprecate the _PROFILER global var (joomla#10845)
  Spelling errors (joomla#11604)
  Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603)
  Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511)
  [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593)
  [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502)
  $result-variable-undefined-given-default-value (joomla#9277)
  com_banners use exceptions. and not allowed is a 403 (joomla#11418)
  Frontend & plugins using the autoloader (joomla#10882)
  New version of PR 6788 (JText::_() Optimizations) (joomla#11235)
  ...
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants