[4.0] Introduce router service

[laoneo]

Pull Request for Issue #19580.

Summary of Changes

The component router is available through the booted component instance when available as services.

Testing Instructions

• Install sample data
• Enable modern routing with no id's
• Browse around on the front end through the articles

Expected result

SEF urls are generated without id's.

Actual result

SEF urls are generated without id's.

[wilsonge]

In this case we don't need a factory - these are all defined classes - so we should just use the DIC's build method here rather than using a factory (https://github.com/joomla-framework/di/blob/master/src/Container.php#L182) - we only need a factory for when we have the magic configuration array's that the DIC doesn't understand

[laoneo]

Type of $app can be changed to SiteApplication and Category to Categories, but for the AbstractMenumenu we do not have a resource in the container.

[laoneo]

Getting rid of the factory would also mean that we set a router in the component directly and do always return the same instance on $app->bootComponent('com_content')->createRouter(); (we should rename then the function to getRouter).

[wilsonge]

and do always return the same instance on $app->bootComponent('com_content')->createRouter();

yes but you wrap it in an anonymous function so it's still lazy loaded

[laoneo]

When you create the ContentComponent then you need an instance no callback. Have a look here, where we pass now the factory. I would love to do it without a factory, I tried different things but none worked to have it in a clean way.

[laoneo]

I need to get this one merged to finish the service conversion of com_contact, com_newsfeeds and com_categories.

[mbabker]

TBH it probably only needs the menu, especially for building routes across applications. Not staring at code but I don’t remember the application being too heavily used in component routers.

On Thu, Aug 30, 2018 at 5:54 PM George Wilson ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In components/com_content/Router/RouterFactory.php <#20339 (comment)>: > + { + $this->category = $category; + $this->db = $db; + } + + /** + * Creates a router. + * + * @param CMSApplicationInterface $application The application + * @param AbstractMenu $menu The menu object to work with + * + * @return RouterInterface + * + * @SInCE __DEPLOY_VERSION__ + */ + public function createRouter(CMSApplicationInterface $application, AbstractMenu $menu): RouterInterface If we have a SiteApplication here (we are aborting if we don't) - why can't we use it's getMenu method? Is there ever a time we need any other instance? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20339 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWfoQuvfLPVzDqbwQONfFo6NV9_vzVvks5uWG07gaJpZM4T52Bw> .

-- - Michael Please pardon any errors, this message was sent from my iPhone.

[laoneo]

Any more feedback?

[wilsonge]

Thankyou!