Fix language keys which trigger wrong plural detection in translation tools #8300
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
While testing Crowdin we found that we have seven language keys in core which are named in a way that triggers plural detection in Crowdin (and probably also other translation tools).
This is because they end with eg "_1". Keys ending directly with a number only are usually used for plural forms.
Solution
This PR deprecates the existing language keys and use new key names for those strings.
According to our rules we don't remove strings within a major series to provide backward compatibility.
Testing
The affected strings are used as options in "Purchase Type" in com_banners component settings, the client and banner forms and the Search Tools in the client manager.
After applying the PR, you should see the english values instead of the translated ones because your language pack doesn't contain a translation (yet) and Joomla will fall back to the english one.
The remaining two are the "Version" parameter in the reCaptcha plugin. However since I doubt that the values are actually different in your language (1.0 likely will be 1.0 as well) you will likely see no difference.