Skip to content

Conversation

@Bakual
Copy link
Contributor

@Bakual Bakual commented Nov 6, 2015

Issue

While testing Crowdin we found that we have seven language keys in core which are named in a way that triggers plural detection in Crowdin (and probably also other translation tools).
This is because they end with eg "_1". Keys ending directly with a number only are usually used for plural forms.

Solution

This PR deprecates the existing language keys and use new key names for those strings.
According to our rules we don't remove strings within a major series to provide backward compatibility.

Testing

The affected strings are used as options in "Purchase Type" in com_banners component settings, the client and banner forms and the Search Tools in the client manager.
After applying the PR, you should see the english values instead of the translated ones because your language pack doesn't contain a translation (yet) and Joomla will fall back to the english one.

The remaining two are the "Version" parameter in the reCaptcha plugin. However since I doubt that the values are actually different in your language (1.0 likely will be 1.0 as well) you will likely see no difference.

@zero-24
Copy link
Contributor

zero-24 commented Nov 6, 2015

I have tested this item ✅ successfully on 882ea81

Works great. Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8300.

@zero-24 zero-24 added this to the Joomla! 3.5.0 milestone Nov 6, 2015
@infograf768
Copy link
Member

No problem here on review.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on 882ea81


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8300.

@infograf768
Copy link
Member

RTC as 2 tests


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8300.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 7, 2015
rdeutz added a commit that referenced this pull request Nov 9, 2015
Fix language keys which trigger wrong plural detection in translation tools
@rdeutz rdeutz merged commit c315c5e into joomla:staging Nov 9, 2015
@Bakual Bakual deleted the NonPluralLanguageKeys branch November 9, 2015 15:29
@wilsonge wilsonge removed the RTC This Pull Request is Ready To Commit label Jan 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants