Skip to content

COM_BANNERS_FIELD_VALUE are taken as plurals #8295

@horus68

Description

@horus68

/administrator/en-GB.com_banners.ini has some similar keys (5) ends by numbers and are considered as Plurals when working with some translation software.
They are not plurals and this caused issues when translating (not all languages has plurals and 5 is to much for all!)
Considering that this strings do not follow the normal way Joomla use for keys they should be changed.

File: https://github.com/joomla/joomla-cms/blob/staging/administrator/language/en-GB/en-GB.com_banners.ini

The keys (line 129):

COM_BANNERS_FIELD_VALUE_1="Unlimited"
COM_BANNERS_FIELD_VALUE_2="Yearly"
COM_BANNERS_FIELD_VALUE_3="Monthly"
COM_BANNERS_FIELD_VALUE_4="Weekly"
COM_BANNERS_FIELD_VALUE_5="Daily"

Should be:

COM_BANNERS_FIELD_VALUE_UNLIMITED="Unlimited"
COM_BANNERS_FIELD_VALUE_YEARLY="Yearly"
COM_BANNERS_FIELD_VALUE_MONTHLY="Monthly"
COM_BANNERS_FIELD_VALUE_WEEKLY="Weekly"
COM_BANNERS_FIELD_VALUE_DAILY="Daily"

Note this other COM_BANNERS_FIELD_VALUE_ on the same file:

COM_BANNERS_FIELD_VALUE_CUSTOM="Custom"
COM_BANNERS_FIELD_VALUE_IMAGE="Image"
COM_BANNERS_FIELD_VALUE_USECLIENTDEFAULT="-- Use Client Default --"
COM_BANNERS_FIELD_VALUE_USECOMPONENTDEFAULT="-- Use Component Default --"

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions