[4.0] Remove deprecated lang stings #12178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zero-24
changed the title
Contributor
|
@zero-24 this has broken com_banners clients http://localhost/github-joomla-cms/administrator/index.php?option=com_banners&view=clients So either the strings were still being used or more likely when @wilsonge created the 4.0 branch he missed the PR that renamed those strings |
Contributor
|
Actually I think the PR which replaced the values wasn't perfect and missed that place. Shame on the writer of that PR (#8300) |
Contributor
Author
|
no problem i'm on it enjoy your holiday :) @Bakual |
Contributor
|
I'm not yet on holidays, one day to go 😄 |
Contributor
|
#12209 should fix that. |
zero-24
added a commit
to zero-24/joomla
that referenced
this pull request
Apr 7, 2018
zero-24
added a commit
to zero-24/joomla
that referenced
this pull request
Apr 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Joomla 4
Summary of Changes
Remove the language strings as per comment on the ini files.
Testing Instructions
Code review
Documentation Changes Required
None