Skip to content

Conversation

@drmenzelit
Copy link
Contributor

com_contact has the possibility to add photos to each contact. The photo can be showed on the view of a single contact, but not in the list of contacts inside a category.
I added two new fields under the List Layouts options to be able to display the contact photo in the list of contacts:
screenshot 141

That is the view (I added Bootstrap 2 and 3 classes to make it compatible with the two versions of the framework):
screenshot 142

I also added a definition into the CSS file of Protostar to correct the display of the rows.

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-staging labels Dec 1, 2015
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should check this #8300 regarding lang vars ending with "_1"

@infograf768
Copy link
Member

Have you tested the CSS with a RTL language?

@drmenzelit
Copy link
Contributor Author

What do you mean infograf768? I used the standard Protostar to test. I think if someone wants to change the order of the columns to show from right to left, then he/she has to create an override of the view.

@infograf768
Copy link
Member

was just wondering about

.contact-category .row {
    margin-left: 0;
}

but, after testing, it looks like it is OK both in RTL and LTR

@drmenzelit
Copy link
Contributor Author

I added this line to the CSS because in Protostar "row" is defined with margin-left: -20px

@waader
Copy link
Contributor

waader commented Dec 9, 2015

I have tested this item ✅ successfully on 7274628

Works fine, thanks! Shouldn´t this also be added to Beez?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@drmenzelit
Copy link
Contributor Author

It can also be added to the override of Beez...

@kleinhelmi
Copy link

I have tested this item ✅ successfully on 7274628

tested with Joomla 3.5.0-beta @ Apache/2.4.10 (Win32) OpenSSL/1.0.1i PHP/5.5.15


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be Column not columns

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @kleinhelmi, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@mikeveeckmans
Copy link

I have tested this item ✅ successfully on 2a8f4f4

TEST OK


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Mar 30, 2016
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@wilsonge
Copy link
Contributor

OK I'm going to make an executive decision here. Can we remove the param for setting column widths please? It's unnecessary - we have far too many params as it is - template overrides are easy to create for that sort of thing

@wilsonge wilsonge removed the RTC This Pull Request is Ready To Commit label Apr 12, 2016
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 13, 2016
@drmenzelit
Copy link
Contributor Author

@wilsonge I removed the parameter for column width

@wilsonge
Copy link
Contributor

Thanks! Now can you add back the installation directory please :)

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@mikeveeckmans
Copy link

ready for test ?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@rdeutz rdeutz added this to the Joomla! 3.6.0 milestone Apr 13, 2016
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

1 similar comment
@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@joomla-cms-bot
Copy link

This PR has received new commits.

CC: @kleinhelmi, @mikeveeckmans, @waader


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@brianteeman
Copy link
Contributor

Closed please retest #9906


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8580.

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 14, 2016
@drmenzelit drmenzelit deleted the image-contact-category-list branch December 9, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants