[5.4] Update deleted files in script.php for the upcoming 5.4.0-beta1

[richard67]

Pull Request for Issue # .

Summary of Changes

This pull request (PR) updates the list of files to be deleted on update in script.php to the latest changes in the 5.4-dev branch, which are the deleted files resulting from following PRs:

• [5.4] Convert mod_latest to service provider #45762 file administrator/modules/mod_latest/mod_latest.php
• [5.4] Convert mod_whosonline to service provider #45775 file modules/mod_whosonline/mod_whosonline.php
• [5.4] Convert mod_logged to service provider #45801 file administrator/modules/mod_logged/mod_logged.php
• [5.4] Convert mod_privacy_dashboard to service provider #45807 file administrator/modules/mod_privacy_dashboard/mod_privacy_dashboard.php
• [5.4] Convert mod_finder to service provider #45815 file modules/mod_finder/mod_finder.php

Testing Instructions

Code review. Check the listed PRs for deleted files and verify that it matches the files being added by this PR to the list.

Or if you want to make a real test:

Update a 5.4.0-alpha3 to the latest 5.4 nightly build for the actual result, and update a 5.4.0-alpha3 to the patched update package or custom update URL created by drone for this PR for the expected result.

Actual result BEFORE applying this Pull Request

The files added by this PR to the list are still there after an update from 5.4.0-alpha3 to 5.4-dev nightly build, however they would not be there when making a new installation with that nightly build.

Expected result AFTER applying this Pull Request

The files added by this PR to the list are deleted after an update from 5.4.0-alpha3 to the patched package of this PR.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[brianteeman]

Can this be automated so it doesnt rely on your availability to make these important pr

[richard67]

Can this be automated so it doesnt rely on your availability to make these important pr

It can not be fully automated as it needs an eye on the result. I am working on a tool to make it easier. But that might take some time as it needs some improvements.

[muhme]

Reviewed changes by:

git clone https://github.com/joomla/joomla-cms
cd joomla-cms
git checkout tags/5.4.0-alpha3
git merge origin/5.4-dev
git diff --name-status 5.4.0-alpha3..HEAD | grep '^D'

✅ Results exactly with the list of added files (exclusive development .-files)

[muhme]

Thank you @richard67 for solving the preparation TODO deleted files for our release build in advance.