[5.2] Remove Toolbar::getInstance() from views

[Hackwar]

Summary of Changes

Toolbar::getInstance() has been deprecated for quite some time now, but the alternative wasn't really clear yet. This PR replaces all occurences with $this->getDocument()->getToolbar() instead. This leaves the Toolbar::getInstance() in the ToolbarHelper class.

Testing Instructions

Codereview

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org:

• No documentation changes for manual.joomla.org needed

[HLeithner]

What the issue @brianteeman ?

[brianteeman]

What the issue @brianteeman ?

1. obvious errors due to blindly search/replace (picked up by drone)
2. stating that no documentation is required.

[HLeithner]

I checked all files but can't find a search replace issue. if you mean the conversation from Toolbar::getInstance('toolbar'); to $this->getDocument()->getToolbar(); without the parameter toolbar this is ok because the default toolbar is toolbar.

on the side I checked some file for missing removal of the use statement for the toolbar which can be removed if not used, as it has been done for some view.

[brianteeman]

Sorry no idea as its been 10 weeks but based on my comment it must have been something shown up in drone so maybe retrigger drone and see

[pe7er]

@Hackwar Could you please remove the unused use Joomla\CMS\Toolbar\Toolbar; statements?

[Hackwar]

Done

[Quy]

Done

I flagged some. There are more to remove.

[Hackwar]

Done

I flagged some. There are more to remove.

No, I thoroughly went through them all at that time and all other instances are still in use.

[laoneo]

@Quy the code style checker should also throw an error when there are unused imports. So I guess we are fine here, or?

[Quy]

@laoneo Yes. Please discard my comments.

[laoneo]

Thanks!