Skip to content

[4.0] Enable button when returning from article#30498

Merged
zero-24 merged 4 commits intojoomla:4.0-devfrom
maliouris:clear-checkboxes-on-back-button
Aug 31, 2020
Merged

[4.0] Enable button when returning from article#30498
zero-24 merged 4 commits intojoomla:4.0-devfrom
maliouris:clear-checkboxes-on-back-button

Conversation

@maliouris
Copy link
Contributor

@maliouris maliouris commented Aug 27, 2020

New pull request for #24328.
In Chromium browsers, when you check a checkbox, you follow a link and then you come back the checkbox is still checked but you can't get that information with javascript. So according to this https://stackoverflow.com/questions/33731067/checkbox-still-checked-hitting-the-back-button-but-it-has-no-checked-attribut I applied the autocomplete='off' and the checkboxes are no longer checked when you come back (as it currently works in Firefox)

@Quy
Copy link
Contributor

Quy commented Aug 28, 2020

I have tested this item ✅ successfully on 8fb8eb7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30498.

1 similar comment
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 8fb8eb7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30498.

@jwaisner
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30498.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 28, 2020
@Quy Quy added the PR-4.0-dev label Aug 28, 2020
@zero-24 zero-24 added this to the Joomla 4.0 milestone Aug 31, 2020
@zero-24 zero-24 merged commit 26240dd into joomla:4.0-dev Aug 31, 2020
@zero-24
Copy link
Contributor

zero-24 commented Aug 31, 2020

Thanks merging

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 31, 2020
@maliouris maliouris deleted the clear-checkboxes-on-back-button branch September 5, 2020 16:54
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…om_templates

* '4.0-dev' of github.com:joomla/joomla-cms: (70 commits)
  [4.0] Child templates consistency (joomla#30387)
  [4.0] favicon changes to support child templates (joomla#30388)
  [4.0] Update Readme for Api tests (joomla#30539)
  [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537)
  [4.0] Display of horizontal mod_articles_news module (joomla#30527)
  [4.0] Useless installation lang strings (joomla#30568)
  [4.0] Numbers not digits (joomla#30559)
  [4.0] Accessibility plugin position (joomla#30552)
  [4.0] fix for inherit fields (joomla#30557)
  [4.0] Redundant words (joomla#30555)
  add missing legend to fieldset (joomla#30528)
  [4.0] [a11y] add statement on found results (joomla#30535)
  [4.0] com_finder ul instead of dl for easier styling (joomla#30534)
  [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516)
  [4.0] Increase API Test Coverage (joomla#26722)
  [4.0] Implementing display of password requirements for frontend (joomla#30473)
  [4.0] FieldsHelper: Choose a first available category  correctly (joomla#30268)
  Sort options (joomla#30531)
  Clear checkboxes on back button (joomla#30498)
  Update _icomoon.scss (joomla#30436)
  ...
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Co-authored-by: Ioannis Maliouris <giannism@e-avenue.eu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments