[4.0] Enable button when returning from article

[maliouris]

Pull Request for Issue # .

Summary of Changes

Fix disabled buttons to enabled when an element is already selected on load.

Testing Instructions

Steps to reproduce the issue. Go to articles, select an article and then press the name of it to edit it. Press the back button to go back and you will see that the buttons change status and batch are disabled and cant be enabled even if you deselect it and then you select it again.

Expected result

Actual result

Documentation Changes Required

[infograf768]

Please use spaces instead of tabs...

[infograf768]

space missing between if and parenthesis
space missing before brace

[infograf768]

This whole part above:
change tabs to spaces.
var should be const

drone/src/github.com/joomla/joomla-cms/build/media_source/system/js/multiselect.es6.js
  29:11  error  All 'var' declarations must be at the top of the function scope  vars-on-top
  29:11  error  Unexpected var, use let or const instead                         no-var
  31:13  error  Unexpected var, use let or const instead                         no-var
  32:1   error  Unexpected tab character                                         no-tabs
  32:2   error  Mixed spaces and tabs                                            no-mixed-spaces-and-tabs
  32:6   error  Unexpected var, use let or const instead                         no-var
  33:1   error  Unexpected tab character                                         no-tabs
  33:2   error  Mixed spaces and tabs                                            no-mixed-spaces-and-tabs
  34:1   error  Expected indentation of 14 spaces but found 16                   indent
  34:17  error  Unexpected var, use let or const instead                         no-var
  34:17  error  All 'var' declarations must be at the top of the function scope  vars-on-top
  35:1   error  Expected indentation of 14 spaces but found 16                   indent
  36:2   error  Mixed spaces and tabs                                            no-mixed-spaces-and-tabs
  36:13  error  Unexpected tab character                                         no-tabs
  37:1   error  Expected indentation of 16 spaces but found 20                   indent
  38:2   error  Mixed spaces and tabs                                            no-mixed-spaces-and-tabs
  38:15  error  Unexpected tab character                                         no-tabs
  38:37  error  A space is required after ','                                    comma-spacing
  39:2   error  Mixed spaces and tabs                                            no-mixed-spaces-and-tabs
  39:13  error  Unexpected tab character                                         no-tabs
  40:1   error  Expected indentation of 12 spaces but found 6 tabs               indent
  40:1   error  Unexpected tab character                                         no-tabs
42:13 error Unary operator '++' used no-plusplus

[infograf768]

http://ci.joomla.org/joomla/joomla-cms/16315/15

[Puneet-Jain-18]

@franz-wohlkoenig The PR is working as expected, what could be possible reason for the failure of continuous-integration/drone/pr test ??

[ghost]

@Puneet-Jain-18 maybe @rdeutz can help (i'm user, no Developer).

[Puneet-Jain-18]

I have tested this item ✅ successfully on fedfc5e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[euismod2336]

I have tested this item ✅ successfully on fedfc5e

works as advertised

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[ghost]

Status "Ready To Commit".

[roland-d]

I have tested this item 🔴 unsuccessfully on fedfc5e

I was unable to reproduce this. What I did was:

1. Check the checkbox
2. Click on the name of the article to edit it
3. Click on the browser back button
4. I get back to the list and the item is not selected anymore

This is using Firefox on Mac.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[roland-d]

@maliouris Thank you for the pull request unfortunately I am unable to reproduce this. Can you check on the current 4.0-dev branch to see if you still have this issue?

[Quy]

Confirmed. OK in Firefox, but not in Chrome.

Click the checkbox next to the article.
Click on the article name to edit.
Click the Back button.

[maliouris]

I use chrome and it works for me how is that possible ? However I made that pull request way too long ago so it might not work now because some of the files that I have changed have been updated since my pull request. I don't know and at the moment I cant find out why it doesn't work as it used to do. I mean I don't have the time to do it. I will give it a try after 2 weeks

[roland-d]

Removing RTC for now until issue can reliably be reproduced and tested.

[ghost]

Status back on "Pending".

[Nilesh5995]

I have tested this item 🔴 unsuccessfully on f087257

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[nidhi1709]

No files were present while applying patch.

[ahghatol]

I have tested this item ✅ successfully on f087257

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[deepa-g]

I have tested this item ✅ successfully on f087257

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[johndeutesfeld]

I have tested this item 🔴 unsuccessfully on f087257

1. Tested as instructed
2. Problem still occurs
Edit: using Chrome
When coming back from the edit window the buttons are still disabled. After de-selecting everything via the the top box and re-selecting the article the buttons are active again but I don't think this is the desired change.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[robinstern]

I have tested this item 🔴 unsuccessfully on f087257

Tested unsuccessfully!

No improvements detected!

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24328.}

[maliouris]

Watch #30498

[Quy]

Please test PR #30498