[4.0] FieldsHelper: Choose a first available category correctly#30268
[4.0] FieldsHelper: Choose a first available category correctly#30268wilsonge merged 4 commits intojoomla:4.0-devfrom
Conversation
|
I have tested this item ✅ successfully on a5eef98 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268. |
|
I have tested this item ✅ successfully on a5eef98 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268. |
|
Do we need this same code in the other places we have this (WorkflowBehaviorTrait and ArticleModel)? |
|
Good question, I did not seen it there, $xml->loadHTML($formField->__get('input'));
$options = $xml->getElementsByTagName('option');Then yes, it also need to be changed. Do not merge it for now, I will check that also |
|
I have updated WorkflowBehaviorTrait and ArticleModel. Please re-check I just have no idea where to test WorkflowBehaviorTrait. |
|
@Quy please restore an yellow label 😉 |
|
I have tested this item ✅ successfully on 861f892 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268. |
|
Thanks! |
|
(Merged as there was two good changes in the main patch and one good test on rolling the same thing out to two other places) |
…om_templates * '4.0-dev' of github.com:joomla/joomla-cms: (70 commits) [4.0] Child templates consistency (joomla#30387) [4.0] favicon changes to support child templates (joomla#30388) [4.0] Update Readme for Api tests (joomla#30539) [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537) [4.0] Display of horizontal mod_articles_news module (joomla#30527) [4.0] Useless installation lang strings (joomla#30568) [4.0] Numbers not digits (joomla#30559) [4.0] Accessibility plugin position (joomla#30552) [4.0] fix for inherit fields (joomla#30557) [4.0] Redundant words (joomla#30555) add missing legend to fieldset (joomla#30528) [4.0] [a11y] add statement on found results (joomla#30535) [4.0] com_finder ul instead of dl for easier styling (joomla#30534) [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516) [4.0] Increase API Test Coverage (joomla#26722) [4.0] Implementing display of password requirements for frontend (joomla#30473) [4.0] FieldsHelper: Choose a first available category correctly (joomla#30268) Sort options (joomla#30531) Clear checkboxes on back button (joomla#30498) Update _icomoon.scss (joomla#30436) ...
Try to fix release blocker #23036 .
Summary of Changes
This is correcting a way to retrieve a first category in list
Testing Instructions
Apply patch, and create a field assigned to specific category.
Then create a new Article to this category and make sure the field is there.
Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Documentation Changes Required
nope
ping @wilsonge