Skip to content

[4.0] FieldsHelper: Choose a first available category correctly#30268

Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom
Fedik:fix-23036
Sep 1, 2020
Merged

[4.0] FieldsHelper: Choose a first available category correctly#30268
wilsonge merged 4 commits intojoomla:4.0-devfrom
Fedik:fix-23036

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Aug 3, 2020

Try to fix release blocker #23036 .

Summary of Changes

This is correcting a way to retrieve a first category in list

Testing Instructions

Apply patch, and create a field assigned to specific category.
Then create a new Article to this category and make sure the field is there.

Actual result BEFORE applying this Pull Request

Works

Expected result AFTER applying this Pull Request

Works

Documentation Changes Required

nope

ping @wilsonge

@SharkyKZ
Copy link
Contributor

SharkyKZ commented Aug 6, 2020

I have tested this item ✅ successfully on a5eef98


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.

@ceford
Copy link
Contributor

ceford commented Aug 7, 2020

I have tested this item ✅ successfully on a5eef98

If it works before and works after applying the patch it is not clear what to look for as a test result.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.

@Quy
Copy link
Contributor

Quy commented Aug 7, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Aug 9, 2020

Do we need this same code in the other places we have this (WorkflowBehaviorTrait and ArticleModel)?

@Fedik
Copy link
Member Author

Fedik commented Aug 10, 2020

Good question, I did not seen it there,
if it use

$xml->loadHTML($formField->__get('input'));
$options = $xml->getElementsByTagName('option');

Then yes, it also need to be changed.

Do not merge it for now, I will check that also

@Quy Quy removed the RTC This Pull Request is Ready To Commit label Aug 10, 2020
@Fedik Fedik requested a review from HLeithner as a code owner August 11, 2020 15:47
@Fedik
Copy link
Member Author

Fedik commented Aug 11, 2020

I have updated WorkflowBehaviorTrait and ArticleModel. Please re-check

I just have no idea where to test WorkflowBehaviorTrait.

@Fedik
Copy link
Member Author

Fedik commented Aug 11, 2020

@Quy please restore an yellow label 😉

@dgrammatiko
Copy link
Contributor

I have tested this item ✅ successfully on 861f892


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30268.

@wilsonge wilsonge merged commit 512a7ce into joomla:4.0-dev Sep 1, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Sep 1, 2020

Thanks!

@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 1, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Sep 1, 2020

(Merged as there was two good changes in the main patch and one good test on rolling the same thing out to two other places)

@Fedik Fedik deleted the fix-23036 branch September 1, 2020 09:46
dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…om_templates

* '4.0-dev' of github.com:joomla/joomla-cms: (70 commits)
  [4.0] Child templates consistency (joomla#30387)
  [4.0] favicon changes to support child templates (joomla#30388)
  [4.0] Update Readme for Api tests (joomla#30539)
  [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537)
  [4.0] Display of horizontal mod_articles_news module (joomla#30527)
  [4.0] Useless installation lang strings (joomla#30568)
  [4.0] Numbers not digits (joomla#30559)
  [4.0] Accessibility plugin position (joomla#30552)
  [4.0] fix for inherit fields (joomla#30557)
  [4.0] Redundant words (joomla#30555)
  add missing legend to fieldset (joomla#30528)
  [4.0] [a11y] add statement on found results (joomla#30535)
  [4.0] com_finder ul instead of dl for easier styling (joomla#30534)
  [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516)
  [4.0] Increase API Test Coverage (joomla#26722)
  [4.0] Implementing display of password requirements for frontend (joomla#30473)
  [4.0] FieldsHelper: Choose a first available category  correctly (joomla#30268)
  Sort options (joomla#30531)
  Clear checkboxes on back button (joomla#30498)
  Update _icomoon.scss (joomla#30436)
  ...
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments