Skip to content

[4.0] Numbers not digits#30559

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
brianteeman:numbers_not_digits
Sep 4, 2020
Merged

[4.0] Numbers not digits#30559
wilsonge merged 2 commits intojoomla:4.0-devfrom
brianteeman:numbers_not_digits

Conversation

@brianteeman
Copy link
Contributor

This corrects the mistake in #30473 - the word should be number not digit

I have checked this with my client Cambridge University Press and they have checked the usage within the Corpus. https://en.wikipedia.org/wiki/Cambridge_English_Corpus The corpus is a multi billion word database of the usage of the english language in the world. The corpus is about how language is used and not just about the dictionary meaning

They wrote

Interesting! I’ve had a look and it looks like ‘number’ is more common – there are only a small number of examples with ‘digit’.
It’s hard to know for sure, as there are only very few examples of the exact sentences you’ve given so I did a more general search and often ‘number’ is used in sentences like ‘they could steal your credit card number and password’. But, I had a scan through and there are definitely lots of examples of e.g. ‘use a password that contains letters, numbers and special characters’, so I think you’re right to go with your feeling on this.

Testing Instructions

Code review

cc @wilsonge

I have checked this with my client Cambridge University Press and they have checked the usage within the Corpus. https://en.wikipedia.org/wiki/Cambridge_English_Corpus The corpus is a multi billion word database of the usage of the english language in the world. The corpus is about how language is used and not just about the dictionary meaning

They wrote

Interesting! I’ve had a look and it looks like ‘number’ is more common – there are only a small number of examples with ‘digit’.

It’s hard to know for sure, as there are only very few examples of the exact sentences you’ve given so I did a more general search and often ‘number’ is used in sentences like ‘they could steal your credit card number and password’. But, I had a scan through and there are definitely lots of examples of e.g. ‘use a password that contains letters, numbers and special characters’, so I think you’re right to go with your feeling on this.
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Sep 3, 2020
@jiweigert
Copy link

I would expect the term "digit" or "digits" more in a specific technical conversation/ documentation like a API-Interface description, not in a usual conversation or message presented to the user as a hint, error or general explanation.

It's not wrong, but highly uncommon, even when I reflect all the documentations, texts and emails i had to write to customers, technical staff or in CMS-Frontend code I had to write in customer projects.

"Number/ numbers" was always the way to go.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30559.

@sandewt
Copy link
Contributor

sandewt commented Sep 3, 2020

A different approach: numbers versus digits

digit: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9 <=> these are just digits

number: 21, 567, 23471 <=> You use the digits to make numbers which represents a certain value.

For example with 6 digits you make a number with a certain value.

Compare this with the letters from the alphabet with which you make words.

@jiweigert
Copy link

Hi sandewt,
we should really not be too technical in presenting messages or anything else, when it come to "communicate" with the users.

Messages should be understandible and that begins with the right choice of terms.

Outside of technical groups I hardly had ever heard the term digit or digits for single numbers.
What's total ok internal, is confusing when it comes to explain something to the (End-)user, here the Infomessage for missing numbers in a password.

The number area on a standard keyboard is called num(ber)pad
not digitpad, the key to lock or unlock it numlock, etc.

That is, what a user can associate with, when he see such Infomessage.

Compare this with the letters from the alphabet with which you make words.

Actually, the word letter is used in sense of printing, painting..
were it's originated from in book printing letters (on to the paper) while typing on a type writer...

characters is used when to write a messages, letters, documents.

But that is nitpicking ;)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30559.

@sandewt
Copy link
Contributor

sandewt commented Sep 4, 2020

@jiweigert

we should really not be too technical in presenting messages or anything else, when it come to "communicate" with the users.

Indeed, the following could be an intermediate solution:

This language string:
JFIELD_PASSWORD_NOT_ENOUGH_INTEGERS_N_1="Password does not have enough numbers. At least 1 number is required."

Could be:
JFIELD_PASSWORD_NOT_ENOUGH_INTEGERS_N_1="Password does not have enough numbers. At least 1 digit is required."

@wilsonge wilsonge merged commit 52fdec6 into joomla:4.0-dev Sep 4, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Sep 4, 2020
@SharkyKZ
Copy link
Contributor

SharkyKZ commented Sep 4, 2020

Digit is the correct term. But I'm not going to argue with native English speakers. My only wish is that a note is added for language translators so they know it should be correctly translated as digit.

@wilsonge
Copy link
Contributor

wilsonge commented Sep 4, 2020

I agree with Brian in this case. numbers is the phrase used most at least in British english.

@infograf768
Copy link
Member

@wilsonge You just killed #30559 as these strings are useless in installation...

@brianteeman brianteeman deleted the numbers_not_digits branch September 4, 2020 10:16
@brianteeman
Copy link
Contributor Author

Thanks @wilsonge

dgrammatiko added a commit to dgrammatiko/joomla-cms that referenced this pull request Sep 29, 2020
…om_templates

* '4.0-dev' of github.com:joomla/joomla-cms: (70 commits)
  [4.0] Child templates consistency (joomla#30387)
  [4.0] favicon changes to support child templates (joomla#30388)
  [4.0] Update Readme for Api tests (joomla#30539)
  [4.0] [Multilingual Status module] Adding displaying a possible error if URL Language Code is empty (joomla#30537)
  [4.0] Display of horizontal mod_articles_news module (joomla#30527)
  [4.0] Useless installation lang strings (joomla#30568)
  [4.0] Numbers not digits (joomla#30559)
  [4.0] Accessibility plugin position (joomla#30552)
  [4.0] fix for inherit fields (joomla#30557)
  [4.0] Redundant words (joomla#30555)
  add missing legend to fieldset (joomla#30528)
  [4.0] [a11y] add statement on found results (joomla#30535)
  [4.0] com_finder ul instead of dl for easier styling (joomla#30534)
  [4.0] Messages/Alerts: using icons instead of text as heading (joomla#30516)
  [4.0] Increase API Test Coverage (joomla#26722)
  [4.0] Implementing display of password requirements for frontend (joomla#30473)
  [4.0] FieldsHelper: Choose a first available category  correctly (joomla#30268)
  Sort options (joomla#30531)
  Clear checkboxes on back button (joomla#30498)
  Update _icomoon.scss (joomla#30436)
  ...
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
I have checked this with my client Cambridge University Press and they have checked the usage within the Corpus. https://en.wikipedia.org/wiki/Cambridge_English_Corpus The corpus is a multi billion word database of the usage of the english language in the world. The corpus is about how language is used and not just about the dictionary meaning

They wrote

Interesting! I’ve had a look and it looks like ‘number’ is more common – there are only a small number of examples with ‘digit’.

It’s hard to know for sure, as there are only very few examples of the exact sentences you’ve given so I did a more general search and often ‘number’ is used in sentences like ‘they could steal your credit card number and password’. But, I had a scan through and there are definitely lots of examples of e.g. ‘use a password that contains letters, numbers and special characters’, so I think you’re right to go with your feeling on this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments