[4.0] WebAsset for components, part 1#29464
Merged
wilsonge merged 14 commits intojoomla:4.0-devfrom Jun 29, 2020
Merged
Conversation
Contributor
|
It's fine to get this in but needs two testers now rather than just me doing review. so you'll need to add test instructions here |
Quy
reviewed
Jun 6, 2020
administrator/components/com_categories/src/View/Categories/HtmlView.php
Show resolved
Hide resolved
Quy
reviewed
Jun 6, 2020
Quy
reviewed
Jun 6, 2020
Member
Author
|
the instruction always there 😉 |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@wilsonge sorry had no time to make it before beta1, I hope it still okay. Other components I try to finish next week.
Summary of Changes
This make components to use WebAsset,
Affected components:
Testing Instructions
Apply patch, run
npm installNavigate around the site, try create/edit content in the component from the list
Inspect source code, you should see component scripts loaded.
Expected result
All works
Actual result
All works
ref #22435