Skip to content

Comments

[4] Use modal.js instead of batch.js in editor when inserting article link#29860

Merged
infograf768 merged 1 commit intojoomla:4.0-devfrom
ReLater:patch-1
Jul 2, 2020
Merged

[4] Use modal.js instead of batch.js in editor when inserting article link#29860
infograf768 merged 1 commit intojoomla:4.0-devfrom
ReLater:patch-1

Conversation

@ReLater
Copy link
Contributor

@ReLater ReLater commented Jun 30, 2020

Fixes #29858

Summary of Changes

  • Replaced wrong asset com_content.admin-articles-batch with com_content.admin-articles-modal

Testing Instructions

Actual result BEFORE applying this Pull Request

  • No insertion of article anchor in editor text.

Expected result AFTER applying this Pull Request

  • Known behavior is back.

@brianteeman
Copy link
Contributor

It would be useful to know which PR broke the behaviour so that we can be certain that the reason for that PR is still resolved after this change

@richard67
Copy link
Member

@brianteeman It was this commit 4d8983f#diff-a42b2b0c3999aaf0517b60ea5d19f8cc from this PR #29464.

As the screenshot shows, the script was com_content/admin-articles-modal.min.js before the change to web asset manager, and it was then changed to $wa->...->useScript('com_content.admin-articles-batch').

j4-pr-29860

So I would say this PR here is correct.

@brianteeman
Copy link
Contributor

Always good to identify where the problem came from, especially when it is a recent bug ;)

@ReLater
Copy link
Contributor Author

ReLater commented Jul 1, 2020

Always good to identify where the problem came from, especially when it is a recent bug

I've checked it before I posted this pr and checked also other changes of that pr. The error is too obvious to waste time with additional descriptions. Anybody can use the History feature on GitHub.

@Quy Quy removed the PR-4.0-dev label Jul 1, 2020
@Quy
Copy link
Contributor

Quy commented Jul 1, 2020

Tested successfully. Unable to mark it in Issue Tracker.

@Quy Quy added the PR-4.0-dev label Jul 1, 2020
@ChristineWk
Copy link

Tested also successfully. No Test This button.

@Quy Quy added the RTC This Pull Request is Ready To Commit label Jul 1, 2020
@infograf768 infograf768 merged commit 7bf6eea into joomla:4.0-dev Jul 2, 2020
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Jul 2, 2020
@infograf768
Copy link
Member

tks

@infograf768 infograf768 added this to the Joomla 4.0 milestone Jul 2, 2020
@ReLater ReLater deleted the patch-1 branch July 2, 2020 11:57
sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants