Skip to content

Comments

[4.0] WebAsset for components, part 2#29496

Merged
wilsonge merged 8 commits intojoomla:4.0-devfrom
Fedik:assets-comp2
Jun 29, 2020
Merged

[4.0] WebAsset for components, part 2#29496
wilsonge merged 8 commits intojoomla:4.0-devfrom
Fedik:assets-comp2

Conversation

@Fedik
Copy link
Member

@Fedik Fedik commented Jun 8, 2020

Second part, prev is #29464, can be tested independently

Summary of Changes

This make components to use WebAsset,
Affected components:

com_media
  /administrator/index.php?option=com_media
  /administrator/index.php?option=com_media&view=file&path=local-0:/joomla_black.png
com_languages
  /administrator/index.php?option=com_languages&view=language&layout=edit&lang_id=1
  /administrator/index.php?option=com_languages&view=override&layout=edit
com_cpanel
  /administrator/index.php
com_config
  /index.php?option=com_config&view=templates
  /index.php?option=com_config&view=modules
  /index.php?option=com_config&view=config
com_actionlogs
  /administrator/index.php?option=com_actionlogs&view=actionlogs
com_cache
  /administrator/index.php?option=com_cache
com_templates
  /administrator/index.php?option=com_templates&view=template&id=211
  /administrator/index.php?option=com_templates&view=style&layout=edit&id=11
com_mails
  /administrator/index.php?option=com_mails&view=template&layout=edit&template_id=com_config.test_mail&language=en-GB

Testing Instructions

Apply patch, run npm install
Navigate around the site, try visit the component from the list, and create/edit content/params in it

Expected result

All works

Actual result

All works

ref #22435

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jun 8, 2020
@jwaisner
Copy link
Member

I have tested this item ✅ successfully on 79be72c

Tested all above locations and made changes to options and was able to successfully save and modify.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29496.

@Quy
Copy link
Contributor

Quy commented Jun 29, 2020

I have tested this item ✅ successfully on 79be72c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29496.

@Quy Quy removed NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.0-dev labels Jun 29, 2020
@Quy
Copy link
Contributor

Quy commented Jun 29, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/29496.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 29, 2020
@Quy Quy added the PR-4.0-dev label Jun 29, 2020
@wilsonge wilsonge merged commit f95d71c into joomla:4.0-dev Jun 29, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester and removed RTC This Pull Request is Ready To Commit labels Jun 29, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Jun 29, 2020
@Fedik Fedik deleted the assets-comp2 branch June 30, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants