[4.0] Improve text in batch modal#28447
Conversation
|
it isn't the word "Action to perform" a little bit misplace/misaligned to the rest of the modal ? |
|
Do we need this question? I think Copy / Move is self explaining and dos not need an extra label. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447. |
|
I have tested this item ✅ successfully on d3192ed Now the text is shorter the flex layout puts logically the radio buttons at the end of the text. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447. |
|
for me we don't need this, but if we need this for newbies then it should be aligned properly |
|
I don't think it matters that we need this specific text in English. So, the aligning needs to be done first, no matter of the text. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447. |
|
I have tested this item ✅ successfully on d3192ed This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447. |
|
Please see PR #28577 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447. |
|
I have tested this item ✅ successfully on d3192ed This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447. |
|
I do not agree with this change to JLIB_HTML_BATCH_MOVE_QUESTION I do agree with changing the order of the words in the text to match the order of the radio. |
|
How about changing |
|
Please check again #28577. |
|
So #28577 has been merged - believe this means we can now handle |
|
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28447. |
|
RTC? |
|
Thanks |
* Joomla/4.0-dev: (844 commits) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) Removing card.scss overrides as we don't use those classes Use renderField() method to render fields (joomla#30738) [4.0] spelling (joomla#30742) [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581) [4.0] Fix saving images (joomla#30730) [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729) Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710) [4.0] Fix Debug plugin to display query parameters (joomla#30717) ...
…ger_events_consistency * '4.0-dev' of github.com:joomla/joomla-cms: (84 commits) [4.0] Error in legacy plugins when method contains $event argument (joomla#30575) [4.0] Cassiopea table css (joomla#30740) [4.0] Blog view links (joomla#30788) Change grid minmax definition for newsflash module (joomla#30781) [4.0] Pluginless lazyloading for the core (joomla#30748) Update package-lock.json (joomla#30713) [4.0] mod_article_news readmore (joomla#30780) Improve code, remove separator (joomla#30785) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) ... � Conflicts: � administrator/components/com_media/resources/scripts/app/Api.js � administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue � package-lock.json
Alternate to #24817.
Summary of Changes
Make Copy/Move label consistent with other labels.
Testing Instructions
Content > Articles > select some articles > click on Batch
Select a category so that the Copy / Move question is shown.
The radio buttons will be fixed if this is approved.
Expected result