Skip to content

[4.0] Alignment of question in batch modal#28577

Merged
wilsonge merged 7 commits intojoomla:4.0-devfrom
chmst:alignment-batch-question
Apr 5, 2020
Merged

[4.0] Alignment of question in batch modal#28577
wilsonge merged 7 commits intojoomla:4.0-devfrom
chmst:alignment-batch-question

Conversation

@chmst
Copy link
Contributor

@chmst chmst commented Apr 4, 2020

Summary of Changes

In the match modal of categories, the move-or-copy question is a text, followed by a select typr radio.
The text ist not tagged as label, which is an a11y issue
and it gives a alignment issue if the text is short - see PR 28447

Testing Instructions

You need a few categories.
mark them, go to action batch
and move or copy categories.

Watch the alignment of the question and the related radio buttons.

Make sure that copy and move works as before.

@conconnl
Copy link
Member

conconnl commented Apr 4, 2020

I have tested this item ✅ successfully on 89f707a

Tested successful in combination with #28447
Radio groups are perfectly aligned with the shorter text.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

@jwaisner
Copy link
Member

jwaisner commented Apr 4, 2020

I have tested this item ✅ successfully on 89f707a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

@jwaisner
Copy link
Member

jwaisner commented Apr 4, 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 4, 2020
@brianteeman
Copy link
Contributor

This should not be RTC for the reasons I commented above

@richard67 richard67 removed the RTC This Pull Request is Ready To Commit label Apr 4, 2020
@richard67
Copy link
Member

Removing RTC since the PR has a for="batch-copy-move-id" but an element with id="batch-copy-move-id" doesn't exist.

Maybe it should have been for="batch-copy-move"?

But then still the other aspects of @brianteeman's comment should be checked.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

@richard67
Copy link
Member

I have tested this item 🔴 unsuccessfully on 89f707a

Code review: An html element with an id as refered to by the "for" attribute doesn't exist.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

@brianteeman
Copy link
Contributor

the fieldest and ID are all good now - thanks

@alikon
Copy link
Contributor

alikon commented Apr 5, 2020

I have tested this item ✅ successfully on 2acc53a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

1 similar comment
@richard67
Copy link
Member

I have tested this item ✅ successfully on 2acc53a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28577.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Apr 5, 2020
@wilsonge wilsonge merged commit db5c523 into joomla:4.0-dev Apr 5, 2020
@wilsonge
Copy link
Contributor

wilsonge commented Apr 5, 2020

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Apr 5, 2020
@wilsonge wilsonge added this to the Joomla 4.0 milestone Apr 5, 2020
@chmst chmst deleted the alignment-batch-question branch April 19, 2020 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

Comments