[4.0] Remove obsolete html code by hans2103 · Pull Request #30737 · joomla/joomla-cms

hans2103 · 2020-09-23T07:31:45Z

Pull Request for Issue # .

Summary of Changes

This PR removes obsolete HTML code. I can see no need for the extra HTML provided.
And... it will benefit the work on the styling of improved Cassiopeia

Testing Instructions

Joomla 4 install
Login in and go to /index.php/component/config?view=config
Apply the path (no npm required)
Refresh the page and even without the wrapping divs, the result is the same.

And the result needs some improvement. Spacing between fieldsets. Cassiopeia Team is working on it.

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

ghost · 2020-09-23T08:25:01Z

I have tested this item ✅ successfully on 8fe3e8c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.}

sandewt · 2020-09-23T13:11:49Z

I have tested this item ✅ successfully on 8fe3e8c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.}

sandewt · 2020-09-23T13:22:47Z

@hans2103 you have deleted class="col-md-12">

What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?

[EDIT]

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.}

richard67 · 2020-09-24T08:49:01Z

What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?

@hans2103 Could you answer that question?

richard67 · 2020-09-24T08:50:25Z

@sandewt I'm a bit confused now. You've tested with success but have doubt on removal of the bootstrap grid class. Is this PR good now or not in your opinion?

chmst · 2020-09-24T09:53:56Z

@sandewt mybe you are speaking about administrator layouts? They are pure bootstrap4. This is a frontend layout where we are working to become independent from any framework.

I have tested the changes successfully.

richard67 · 2020-09-24T09:56:07Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.}

sandewt · 2020-09-24T10:13:52Z

@richard67 ,

I started from the expertise of @hans2103 😃
Afterwards I had asked the question before testing.

sandewt · 2020-09-24T10:25:43Z

@chmst ,

Do not look too much behind it.
Searching on the core code (class="col-md-12") will yield various hits.
I would like an answer to my question for a better understanding.

richard67 · 2020-09-24T10:32:14Z

@sandewt I could see only a 3 php files outside the administrator area beside the onde handled by this PR here where it is used:

./installation/tmpl/preinstall/default.php
./components/com_config/tmpl/templates/default.php
./components/com_config/tmpl/modules/default.php

The classed refer to bootstrap grid, and it might be that they are removed from these places, too.

@hans2103 Do you agree?

hans2103 · 2020-09-24T11:26:50Z

@hans2103 you have deleted class="col-md-12">

What makes this code obsolate?
There are other templates with this html code. Is there also obsolate html code?

[EDIT]

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30737.

it depends and that shall have to be investigated per situation. But that is beyond the scope of this PR

sandewt · 2020-09-24T12:31:48Z

I could see only a 3 php files outside the administrator area beside the onde handled by this PR here where it is used:

@richard67 Correct.

Addition:
The System - HTTP Headers file: ...\plugins\system\httpheaders\httpheaders.xml is located outside the administrator but is only visible there, also contains class="col-md-12" (probably nothing new).

sandewt · 2020-09-24T12:39:59Z

it depends and that shall have to be investigated per situation. But that is beyond the scope of this PR

Then my test is actually worthless. 😏

richard67 · 2020-09-24T12:42:17Z

@sandewt So what have you tested then? Have you tested as described, and it was successful, like you marked your test result? Or not? Shall I reset your test result?

brianteeman · 2020-09-24T12:58:02Z

This code was introduced in #19230

sandewt · 2020-09-24T13:06:43Z

Shall I reset your test result?

@richard67 No worry. I followed the test instructions above exactly. And it was successful.

But experience teaches that sometimes you have to look a little further, hence my question to @hans2103. Or is that not the intention when testing? I have doubts now.

hans2103 · 2020-09-24T13:15:01Z

This code was introduced in #19230

@brianteeman thank you for this reference to the origin of this addition.

As you can see at my screenshot and hopefully also on all of your installations the issue as described on #19230 does not appear after applying this PR.
When merged some simple css we are working on in joomla/cassiopeia ensures proper styling between the fieldset

Quy · 2020-09-24T18:43:06Z

Thanks!

* Joomla/4.0-dev: (844 commits) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) Removing card.scss overrides as we don't use those classes Use renderField() method to render fields (joomla#30738) [4.0] spelling (joomla#30742) [4.0] Remove use of ReflectionParameter::getClass() (joomla#30581) [4.0] Fix saving images (joomla#30730) [4.0] Cleanup cassiopeia chromes and rename "default" to "card" (joomla#30729) Fix hiddenLabel and add hiddenLegend form attribute (joomla#29710) [4.0] Fix Debug plugin to display query parameters (joomla#30717) ...

…ger_events_consistency * '4.0-dev' of github.com:joomla/joomla-cms: (84 commits) [4.0] Error in legacy plugins when method contains $event argument (joomla#30575) [4.0] Cassiopea table css (joomla#30740) [4.0] Blog view links (joomla#30788) Change grid minmax definition for newsflash module (joomla#30781) [4.0] Pluginless lazyloading for the core (joomla#30748) Update package-lock.json (joomla#30713) [4.0] mod_article_news readmore (joomla#30780) Improve code, remove separator (joomla#30785) [4.0] Template layout select (joomla#30772) [4.0][CLI] com_finder use console command (joomla#30768) [4.0] Modifying com_actionlogs string (joomla#30758) [4.0] Fancy selectbox fix (joomla#30739) [4.0] Add missing Table Caption (joomla#30763) [4.0] Wrap all buttons in btn-group to improve styling (joomla#30761) [4.0] Cassiopeia missing string (joomla#30765) Improve batch text (joomla#28447) Fix icons not displaying (joomla#30749) Remove the chrome "cardGrey". The same effect can be achieved by using the module class "card-grey" with the "card" chrome (joomla#30734) Remove obsolete html code (joomla#30737) [4.0] Check out improvements related to nullable columns (joomla#30747) ... � Conflicts: � administrator/components/com_media/resources/scripts/app/Api.js � administrator/components/com_media/resources/scripts/components/toolbar/toolbar.vue � package-lock.json

Remove obsolete html code

8fe3e8c

joomla-cms-bot added the PR-4.0-dev label Sep 23, 2020

hans2103 changed the title ~~Remove obsolete html code~~ [4.0] Remove obsolete html code Sep 23, 2020

hans2103 mentioned this pull request Sep 23, 2020

Several improvements to solve several issues joomla/cassiopeia#99

Merged

richard67 removed the PR-4.0-dev label Sep 24, 2020

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Sep 24, 2020

richard67 added the PR-4.0-dev label Sep 24, 2020

Quy added this to the Joomla 4.0 milestone Sep 24, 2020

Quy merged commit fdfeda2 into joomla:4.0-dev Sep 24, 2020

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 24, 2020

hans2103 deleted the patch-6 branch September 24, 2020 19:16

sakiss pushed a commit to sakiss/joomla-cms that referenced this pull request Oct 16, 2020

Remove obsolete html code (joomla#30737)

1eafed9

Uh oh!

Conversation

hans2103 commented Sep 23, 2020

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Uh oh!

ghost commented Sep 23, 2020

Uh oh!

sandewt commented Sep 23, 2020

Uh oh!

sandewt commented Sep 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Sep 24, 2020

Uh oh!

richard67 commented Sep 24, 2020

Uh oh!

chmst commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

richard67 commented Sep 24, 2020

Uh oh!

sandewt commented Sep 24, 2020

Uh oh!

sandewt commented Sep 24, 2020

Uh oh!

richard67 commented Sep 24, 2020

Uh oh!

hans2103 commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandewt commented Sep 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandewt commented Sep 24, 2020

Uh oh!

richard67 commented Sep 24, 2020

Uh oh!

brianteeman commented Sep 24, 2020

Uh oh!

sandewt commented Sep 24, 2020

Uh oh!

hans2103 commented Sep 24, 2020

Uh oh!

Quy commented Sep 24, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sandewt commented Sep 23, 2020 •

edited

Loading

chmst commented Sep 24, 2020 •

edited

Loading

hans2103 commented Sep 24, 2020 •

edited

Loading

sandewt commented Sep 24, 2020 •

edited

Loading