[4.0] Fix Module XTD position and type filters by adding client property to these fields#28259
Merged
HLeithner merged 2 commits intojoomla:4.0-devfrom Mar 9, 2020
Merged
Conversation
Quy
reviewed
Mar 7, 2020
administrator/components/com_modules/src/Field/ModulesModuleField.php
Outdated
Show resolved
Hide resolved
Quy
reviewed
Mar 7, 2020
administrator/components/com_modules/src/Field/ModulesPositionField.php
Outdated
Show resolved
Hide resolved
Contributor
|
I have tested this item ✅ successfully on d2e2c88 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28259. |
1 similar comment
Member
|
I have tested this item ✅ successfully on d2e2c88 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28259. |
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28259. |
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #28119
Replaces #28220 which was not sufficient
Summary of Changes
Forcing correct list of modules positions and type in module xtd searchtools filters by adding client property to the fields as done in #24698 (Thanks @SharkyKZ for the idea)
Testing Instructions
Display Administrator Modules Manager.
Edit/create an article in backend.
Select CMS Content => Module
Display filters
Then patch and test again
Before patch
Wrong type and positions in the filters
After patch