[4.0] Fixing Module xtd filters

[infograf768]

Pull Request for Issue #28220

Summary of Changes

Forcing client id to site

Testing Instructions

See #28220

Before patch

Wrong type and positions in the filters

After patch

[brianteeman]

I have tested this item ✅ successfully on eba21d4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28221.}

[jwaisner]

I have tested this item ✅ successfully on eba21d4

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28221.}

[jwaisner]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28221.}

[wilsonge]

This isn’t the correct fix. First I’m unsure whether all modals are always displaying site modules. If this is the case then make the change here

https://github.com/infograf768/joomla-cms/blob/eba21d47cce29c2f6d1bab6d8ee23e3569851494/administrator/components/com_modules/src/Model/ModulesModel.php#L110 Removing the client site check from the if statement

[infograf768]

I can't find another use of this modal.
the code you point to should work as it is a IF OR

		// Special case for the client id.
		if ($app->isClient('site') || $layout === 'modal')
		{
			$this->setState('client_id', 0);
			$clientId = 0;
		}

but it does not... thus why I used this solution.

[infograf768]

Folks, if I trust my last tests here, this is no more an issue.
Could someone confirm?

[brianteeman]

confirmed

[infograf768]

In fact, we still have the issue if the user has first displayed the Admin modules manager.
In that case the client id is admin.
Thanks @SharkyKZ for finding out

[brianteeman]

ah that makes sense

[infograf768]

This is not working anymore. Closing

[SharkyKZ]

I would suggest doing this similarly to #24698 so we don't have to use user state in field class.

[infograf768]

@SharkyKZ
Good idea.

[infograf768]

Please test new PR #28259