[4.0] loadmodulebyid fix strict comparison#28269
[4.0] loadmodulebyid fix strict comparison#28269alikon wants to merge 1 commit intojoomla:4.0-devfrom alikon:patch-109
Conversation
|
Please test first |
|
There's already PR for staging #26531. But it's also wrong. |
|
why this is wrong ? |
|
Read the comments in #26531. |
|
umm i was testing with postgresql....i'll look with mysql ..... |
|
work with mysql as well |
|
I have tested this item ✅ successfully on b12efc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269. |
|
I have tested this item ✅ successfully on b12efc0 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269. |
|
No RTC. This breaks PDO. |
|
Set back to Pending. This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28269. |
|
@SharkyKZ may i ask you to test on PDO please ? |
|
PDO returns strings for numeric columns when using pdo_mysql. |
|
This seems to be because the driver is using |
|
closing as this will be probably fixed when #28278 will land in 4 branch |
Pull Request for Issue # .
Summary of Changes
cast to int to fix strict comparison
Testing Instructions
create/edit an article
click on CMS Content and select
select a module to embed in the article
save the article
Expected result
the module output is showed in the article
Actual result
no module output