[4.0] Add client property to module positions field#24698
Merged
wilsonge merged 1 commit intojoomla:4.0-devfrom Apr 23, 2019
SharkyKZ:j4/modulesPositionEdit
Merged
[4.0] Add client property to module positions field#24698wilsonge merged 1 commit intojoomla:4.0-devfrom SharkyKZ:j4/modulesPositionEdit
wilsonge merged 1 commit intojoomla:4.0-devfrom
SharkyKZ:j4/modulesPositionEdit
Conversation
Member
|
I have tested this item ✅ successfully on a8f0a5b This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24698. |
|
@chmst can you please test? |
Contributor
|
I'm much happy with this. Merging. Thanks! |
fancyFranci
pushed a commit
to fancyFranci/joomla-cms
that referenced
this pull request
Apr 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #24575.
Summary of Changes
Alternative PR to #24583. Adds client property to module position edit field.
Testing Instructions
Edit a module from:
Inspect positions in
Positionfield.Expected result
Positions should be shown based on whether site or admin module is being edited.
Actual result
When editing an admin module from Control Panel, site positions are shown.
Documentation Changes Required
IDK.