[4.0][com_finder] move finder menu items from sidebar to menu

[alikon]

Summary of Changes

Moved menu items for smart search below the "Smart Search" menu item in the admin menu and removed the sidebar items

Expected result

[brianteeman]

Didn't I already do this ages ago

[alikon]

yes #26137 or #24020
but you have used sql script for menu table which is dangerous for nested set tables like #__menu

[richard67]

Drone failure seems not to be related to this PR.

[richard67]

@alikon As I can see, @brianteeman has closed his PR #26137, and PR #24020 is by @Hackwar .

[Quy]

No submenu shown using your branch and dev branch with Patchtester.

[richard67]

Issues with that update package linked above and e.g. untranslated texts in backend are not related to this PR, they happen also with the unmodified update package from tonight's nightly build.

[Quy]

Upgraded successfully with no sample data, but failed with sample data.

[richard67]

@Quy Which kind of sample data? Blog? Testing? Multilingual? Btw. after update there might be problems with language files not being deleted because deleted files list in script.php is not up to date, but that's another thing not related to this PR, just wanted to mention.

[Quy]

Installed Test English.

[richard67]

@Quy I see. Will test later, too.

[richard67]

@Quy Confirmed. But not related to this PR. Will you make a new issue? Unfortunately I see nothing in mysql or php log about the reason, but I can investigate and try to find a fix now as I can reprocude it.

[richard67]

@Quy I think I have a solution. Will test and make PR.

[richard67]

@Quy PR #27228 is almost ready. I only have to provide testing instructions and a modified update package. The problem is that I have other, unrelated problems with language stings with update packages from current nightly build, which makes testing not nice.

[richard67]

@Quy PR #27228 is ready, please test. And if it works, maybe you can modify the update zip containter I provided in some comment and my test result above by that change and give this PR here a good test, too?

[Quy]

I have tested this item ✅ successfully on d7c03e7

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27032.}

[Quy]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27032.}

[HLeithner]

@wilsonge can we merge this? looks correct for me

[wilsonge]

Thanks!