Skip to content

[4.0] Smart Search submenu#31492

Merged
wilsonge merged 2 commits intojoomla:4.0-devfrom
brianteeman:search_terms
Nov 26, 2020
Merged

[4.0] Smart Search submenu#31492
wilsonge merged 2 commits intojoomla:4.0-devfrom
brianteeman:search_terms

Conversation

@brianteeman
Copy link
Contributor

Smart Search has a submenu called statistics and a toolbar button called statistics which are different things

This was originally changed with PR #26278 but was mistakenly reverted in error with #27032

Smart Search has a submenu called statistics and a toolbar button called statistics which are different things

This was originally changed with PR joomla#26278 but was mistakenly reverted in error with joomla#27032
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-4.0-dev labels Nov 26, 2020
@infograf768
Copy link
Member

I have tested this item ✅ successfully on e38f2d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31492.

@toivo
Copy link
Contributor

toivo commented Nov 26, 2020

I have tested this item ✅ successfully on e38f2d1

Tested successfully in Beta6-dev of 26 November


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31492.

@infograf768
Copy link
Member

Do we need the same string in the .ini ?

@brianteeman
Copy link
Contributor Author

It didnt appear so

@infograf768
Copy link
Member

It didnt appear so

then it looks like the .ini one can be deleted in this PR

@brianteeman
Copy link
Contributor Author

After recent comments I am unwilling to remove any strings until that is clarified

@infograf768
Copy link
Member

The string was wrongly added in https://github.com/joomla/joomla-cms/pull/27032/files#diff-12f24be81fa3503f61f2e45ec78f985d0b71500c1bfede514206bd72674d08bbR195 (line 195) to replace the submenu one which is now correctly in the sys.ini and righfully corrected by this PR. Nothing to do anyway with b/c.

@infograf768
Copy link
Member

I have tested this item ✅ successfully on d824125

Other tests are still OK as last change only concerns deleting a useless string


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31492.

@infograf768
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31492.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Nov 26, 2020
@infograf768 infograf768 added this to the Joomla 4.0 milestone Nov 26, 2020
@wilsonge wilsonge merged commit fe73847 into joomla:4.0-dev Nov 26, 2020
@wilsonge
Copy link
Contributor

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Nov 26, 2020
@brianteeman
Copy link
Contributor Author

Thanks

@brianteeman brianteeman deleted the search_terms branch November 26, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language Change This is for Translators

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants