[4.0] Moving comfinder from submenu to main menu#26137
Closed
brianteeman wants to merge 11 commits intojoomla:4.0-devfrom
Closed
[4.0] Moving comfinder from submenu to main menu#26137brianteeman wants to merge 11 commits intojoomla:4.0-devfrom
brianteeman wants to merge 11 commits intojoomla:4.0-devfrom
Conversation
Quy
reviewed
Sep 2, 2019
C-Lodder
reviewed
Sep 2, 2019
Contributor
You don't, it needs to be done in PHP. See this method in 3.x script.php file. |
Contributor
Author
|
So whoever writes the upgrade scripts can do that. |
Contributor
|
Revert |
Quy
reviewed
Sep 4, 2019
Quy
reviewed
Sep 4, 2019
Contributor
Author
|
Closed. Not trying again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft replacement for #24020
This is just for mysql clean installs
@roland-d If this works then I will add the postgres install
Not sure I know how to do an update sql for this though due to the lft/rgt changes