[4.0] Moving com_finder submenu to mainmenu

[Hackwar]

This adds menu item types for com_finder views, removes the submenu and adds them into the mainmenu.

How to test

1. Apply patch
2. Go to database view and click on "fix"
3. Go to menu manager -> All menu items and click "rebuild"
4. See that the Smart Search menu item can now open up and contains 4 sub menu items and that the submenu in the actual views has been removed.

[brianteeman]

Please alpha sort the language file and check to see if we need the _DESC - most of those are completely unnecessary and we have in general removed all _DESC from J4

[Hackwar]

Fixed the language string. The DESC string is maybe not necessary, but it is still used everywhere (100+ results if you search for it) so if you want to remove those, please do that consistently in another PR.

[brianteeman]

@Hackwar It has already been done. The only _DESC strings that remain are the few that we are still displaying and the _DESC strings that are for DESCENDING not DESCRIPTION

[Hackwar]

No, it hasn't been done, because these strings are fresh from the backend menu items of com_content.

[brianteeman]

[Hackwar]

https://github.com/joomla/joomla-cms/pull/24020/files#diff-1cea33e0f389319a3d2adc85965a3e72R5

[Hackwar]

There are currently 40 default.xml files with a DESC string in them in /administrator/components, excluding the 4 that I've added in this PR. As I said, if that is not wanted/allowed anymore, then please open a PR that removes all these.

[brianteeman]

Sorry I didnt realise they were for the menu descriptions. Those are being kept - its the _desc that were used as tooltips that have gone .

/me needs coffee

[brianteeman]

I have tested this item 🔴 unsuccessfully on 544ace4

Followed test instructions but didnt get a sub menu

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[infograf768]

I have tested this item ✅ successfully on 8ac7581

tested OK on a clean install

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[infograf768]

@Hackwar
Also please solve conflicts.

[Hackwar]

I can't see the error that I have in the postgres SQL file. Could someone have a look here?

[Hackwar]

Tests have passed now.

[Quy]

I have tested this item ✅ successfully on e525eb7

OK with new install.
No submenus when updating using Patchtester, but it might be an issue with Patchtester. Manually ran update SQL successfully.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[chmst]

I have tested this item ✅ successfully on e525eb7

Tested successfully with new installation.

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[Hackwar]

Could those who tested this earlier, please test again, so that we can merge this?

[richard67]

@Hackwar You should adjust your testing instructions. The Database Fix will not run the insert statements in the schema update because it only handles DDL, as I mentioned in in my comment above. People either have to do a clean install or they have to run the insert statements from the schema update in PhpMyAdmin (or PgMyAdmin if PostgreSQL) after having applied the patch.

[brianteeman]

Please remove the composer.lock file

[brianteeman]

I have tested this item 🔴 unsuccessfully on 822d13b

Work ok on a clean install
Does not work on an update - no submenus - and yes I did paste the sql into phpmyadmin

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[bees4ever]

Unfortunaltely it is not wokring for me.

Submenu in the actual views has been removed but there are no 4 sub items in the menu.

[bees4ever]

I have tested this item 🔴 unsuccessfully on 7e9fac5

Unfortunaltely it is not wokring for me.

see #24020 (comment)

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[roland-d]

@Hackwar For me this also doesn't work. The submenu items are gone after applying the patch but the Fix database and Menu Rebuild doesn't add it to the submenu.

[roland-d]

I have tested this item 🔴 unsuccessfully on 7e9fac5

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[brianteeman]

@roland-d can you or one of the students confirm my finding that it was ok on a clean install. Also re your comment about database fix see #24020 (comment)

[roland-d]

@brianteeman The test done by @bees4ever was on a clean installation as in he cloned the repo, installed J4 and did the test.

[brianteeman]

@roland-d can you or the students test #26137

[nadjak77]

I have tested this item 🔴 unsuccessfully on 7e9fac5

not sure if I understand the right way.
point 4: if I do a new menu item "smart search" there is still only one submenu

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}

[Quy]

Please test PR #27032

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/24020.}