[4.0] Fix: Saving menu item fails. Call to a member function validate() on bool. Field "show_associations"

[wilsonge]

Pull Request for Issue #23696

Related and already merged fix: #23501

I think this is a better alternative fix to #23700 ?

Testing Instructions

Install a J4 nightly build of today (Monday, 28 January 2019) or update an older J4 with that package

Go to menu items manager in back-end.

Open Home menu item (type "Articles > Featured Articles")

Save it.

Error like described in #23696 (comment)

Apply patch

Try again to save the menu item.

Should be successful.

[SharkyKZ]

Need the same in filter().

[wilsonge]

@SharkyKZ fixed :)

[ReLater]

I have tested this item ✅ successfully on c1e7e3b

Saving of articles works, too. After reverting pr #23501

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.}

[infograf768]

Saving of articles works, too. After reverting pr #23501

How is that? We still miss merging #23638
here I get

Error
Save failed with the following error: Incorrect integer value: '' for column 'hits' at row 1

why revert #23501 ?

[infograf768]

I have tested this item ✅ successfully on 2102697

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.}

[infograf768]

@ReLater
Why reverting #23501 ? I tested here after disabling languagefilter and therefore show_associations not displaying when editing article Options grace to #23501 and it works fine.

[ReLater]

@infograf768

why revert #23501 ?

Because I could create/save Articles, too, after reverting ONLY these lines of #23501:

// Remove show_associations field if associations is not enabled
		if (!$assoc)
		{
			$form->removeField('show_associations', 'attribs');
		}

So, I think that we don't need the additional fix in 23501 anymore with this pr here. Wasn't that one of the purposes of the discussion about "hardcoded field names"?

[ReLater]

And the show_associations field is not displayed in a mono-lang page in article edit form.

[infograf768]

@ReLater
Yep, you are right. We can now delete the lines you quote above as the AssocField take care of that.
@wilsonge
Can you add that to your PR?

[wilsonge]

PR Amended

[infograf768]

I have tested this item ✅ successfully on b2eca8e

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.}

[alikon]

I have tested this item ✅ successfully on 4a69575

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.}

[infograf768]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23716.}