Skip to content

Comments

[4.4] Fixes to form validation process#42560

Merged
MacJoom merged 1 commit intojoomla:4.4-devfrom
wilsonge:form-bug-fix
Dec 23, 2023
Merged

[4.4] Fixes to form validation process#42560
MacJoom merged 1 commit intojoomla:4.4-devfrom
wilsonge:form-bug-fix

Conversation

@wilsonge
Copy link
Contributor

Fixes hardening measure introduced in #23716

Summary of Changes

In the linked PR I forbid submitting by adding an exception into the validation process. Unfortunately I didn't make the method return false in order to make sure that message was used. This fixes that.

Alongside it improves the documentation around the getError's method. It hasn't returned any strings since 3.0 (and even maybe further - I wasn't sure about how the JException objects were exactly being passed around).

Testing Instructions

Code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Fixes hardening measure introduced in joomla#23716
@SniperSister
Copy link
Contributor

Looks good from my side!

@richard67
Copy link
Member

I have tested this item ✅ successfully on c246730

Code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42560.

@richard67
Copy link
Member

Looks good from my side!

@SniperSister Does this count as successful test? If so, could you mark the test result in the issue tracker, or shall I do that for you, so I can set RTC?

@SniperSister
Copy link
Contributor

I have tested this item ✅ successfully on c246730


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42560.

@richard67
Copy link
Member

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42560.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 22, 2023
@MacJoom MacJoom self-assigned this Dec 23, 2023
@MacJoom MacJoom added this to the Joomla! 4.4.2 milestone Dec 23, 2023
@MacJoom MacJoom merged commit 58ccc93 into joomla:4.4-dev Dec 23, 2023
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 23, 2023
@wilsonge wilsonge deleted the form-bug-fix branch December 23, 2023 18:39
Razzo1987 added a commit that referenced this pull request Jan 4, 2024
* Fix link and button colors in header footer (#42504)

* [4.x] add php 8.3 to tests (#42545)

* Update the signature for #42545 (#42552)

* [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550)

* Better English (1)

* Better English (2)

* Remove br html element from language strings

* Fixes to form validation process (#42560)

Fixes hardening measure introduced in #23716

* [4][com_actionlogs] missed load plugin languages (#42562)

* load lang

* test-4-dupkey

* Better message on package uninstallation (#42570)

* Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

* backport #41865 (#42088)

* backport [5] update from nightly to latest nightly build #41865

* [5] harmonize naming task types (#42574)

* [5.0] colour contrast in media manager file list [a11y] (#42544)

* [5.0] Update phpseclib to 3.0.34 (#42469)

* Fix `function` parameter lost during redirect (#42315)

* Fix `function` parameter lost during redirect

* Move function parameter to form url

* Remove hidden input

* [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576)

* Use concat of columns for getting core extensions

* Fix PHPCS

* Remove wrong quotes

* Revert min version in drone (#42583)

* Joomla! 5.0.2 Release Candidate 1

* Revert to dev

* [4][com_templates] cast to int for pgsql (#42569)

* cast to int for pgsql

* yet-another

* patch article tags (#42486)

* Joomla 5.0.2 Release Candidate 2

* Reset to dev

* Update signature HMAC in .drone.yml

---------

Co-authored-by: Rick Spaan <rick@r2h.nl>
Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Benjamin Trenkle <benjamin.trenkle@wicked-software.de>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: janschoenherr <jan@yootheme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants