[4.0] - fix save article#23638
Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom Feb 4, 2019
alikon:patch-107
Merged
Conversation
Contributor
|
I have tested this item ✅ successfully on ae12205 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23638. |
Contributor
Author
|
just curious why drone complain for analysis4x ??? |
Contributor
|
I have tested this item ✅ successfully on ae12205 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23638. |
Contributor
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23638. |
Member
|
Restarted drone. |
Contributor
|
Thanks! |
|
I have tested this item ✅ successfully on ae12205 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #23617
Summary of Changes
the comment few lines above 😄
/**
* Ensure any new items have compulsory fields set. This is needed for things like
* frontend editing where we don't show all the fields or using some kind of API
*/
Testing Instructions
see #23617
Expected result
save article works
Actual result
don't