Skip to content

[4.0] - fix save article#23638

Merged
wilsonge merged 4 commits intojoomla:4.0-devfrom
alikon:patch-107
Feb 4, 2019
Merged

[4.0] - fix save article#23638
wilsonge merged 4 commits intojoomla:4.0-devfrom
alikon:patch-107

Conversation

@alikon
Copy link
Contributor

@alikon alikon commented Jan 22, 2019

Pull Request for Issue #23617

Summary of Changes

the comment few lines above 😄

/**
* Ensure any new items have compulsory fields set. This is needed for things like
* frontend editing where we don't show all the fields or using some kind of API
*/

Testing Instructions

see #23617

Expected result

save article works

Actual result

don't

@amitranjan2
Copy link
Contributor

I have tested this item ✅ successfully on ae12205


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23638.

@alikon
Copy link
Contributor Author

alikon commented Jan 22, 2019

just curious why drone complain for analysis4x ???

@Quy
Copy link
Contributor

Quy commented Jan 22, 2019

I have tested this item ✅ successfully on ae12205


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23638.

@Quy
Copy link
Contributor

Quy commented Jan 22, 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23638.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2019
@infograf768
Copy link
Member

Restarted drone.

@wilsonge wilsonge merged commit 8617350 into joomla:4.0-dev Feb 4, 2019
@wilsonge
Copy link
Contributor

wilsonge commented Feb 4, 2019

Thanks!

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Feb 4, 2019
@wilsonge wilsonge added this to the Joomla 4.0 milestone Feb 4, 2019
@alikon alikon deleted the patch-107 branch February 4, 2019 10:42
@Leen29
Copy link

Leen29 commented Feb 7, 2019

I have tested this item ✅ successfully on ae12205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants