Skip to content

[5.0] colour contrast in media manager file list [a11y]#42544

Merged
bembelimen merged 3 commits intojoomla:5.0-devfrom
brianteeman:media-contrast
Dec 30, 2023
Merged

[5.0] colour contrast in media manager file list [a11y]#42544
bembelimen merged 3 commits intojoomla:5.0-devfrom
brianteeman:media-contrast

Conversation

@brianteeman
Copy link
Contributor

@brianteeman brianteeman commented Dec 18, 2023

Pull Request for Issue #42541

Summary of Changes

Fix a11y contrast issue in media manager

Testing Instructions

Select an element in media, list view. The selected element has should have color white

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.0-dev labels Dec 18, 2023
@Quy
Copy link
Contributor

Quy commented Dec 18, 2023

@Quy
Copy link
Contributor

Quy commented Dec 18, 2023

I have tested this item ✅ successfully on 276521b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42544.

@viocassel
Copy link
Contributor

I have tested this item ✅ successfully on 276521b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42544.

@Quy
Copy link
Contributor

Quy commented Dec 20, 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42544.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Dec 20, 2023
@richard67 richard67 added the bug label Dec 30, 2023
@bembelimen bembelimen merged commit 9248355 into joomla:5.0-dev Dec 30, 2023
@bembelimen
Copy link
Contributor

Thx

@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Dec 30, 2023
@bembelimen bembelimen added this to the Joomla! 5.0.2 milestone Dec 30, 2023
@brianteeman brianteeman deleted the media-contrast branch December 30, 2023 22:00
Razzo1987 added a commit that referenced this pull request Jan 4, 2024
* Fix link and button colors in header footer (#42504)

* [4.x] add php 8.3 to tests (#42545)

* Update the signature for #42545 (#42552)

* [4.4] Joomlaupdate remove br tag from language strings - follow up to PR 42489 (#42550)

* Better English (1)

* Better English (2)

* Remove br html element from language strings

* Fixes to form validation process (#42560)

Fixes hardening measure introduced in #23716

* [4][com_actionlogs] missed load plugin languages (#42562)

* load lang

* test-4-dupkey

* Better message on package uninstallation (#42570)

* Better message on package uninstallation when an extension from that package is missing. Fixes issue #42537 .

* backport #41865 (#42088)

* backport [5] update from nightly to latest nightly build #41865

* [5] harmonize naming task types (#42574)

* [5.0] colour contrast in media manager file list [a11y] (#42544)

* [5.0] Update phpseclib to 3.0.34 (#42469)

* Fix `function` parameter lost during redirect (#42315)

* Fix `function` parameter lost during redirect

* Move function parameter to form url

* Remove hidden input

* [4.4] Fix SQL error "1104 The SELECT would examine more than MAX_JOIN_SIZE rows" when checking for core updates (#42576)

* Use concat of columns for getting core extensions

* Fix PHPCS

* Remove wrong quotes

* Revert min version in drone (#42583)

* Joomla! 5.0.2 Release Candidate 1

* Revert to dev

* [4][com_templates] cast to int for pgsql (#42569)

* cast to int for pgsql

* yet-another

* patch article tags (#42486)

* Joomla 5.0.2 Release Candidate 2

* Reset to dev

* Update signature HMAC in .drone.yml

---------

Co-authored-by: Rick Spaan <rick@r2h.nl>
Co-authored-by: Christian Heel <66922325+heelc29@users.noreply.github.com>
Co-authored-by: Allon Moritz <allon.moritz@digital-peak.com>
Co-authored-by: Richard Fath <richard67@users.noreply.github.com>
Co-authored-by: Brian Teeman <brian@teeman.net>
Co-authored-by: George Wilson <georgejameswilson@googlemail.com>
Co-authored-by: Nicola Galgano <optimus4joomla@gmail.com>
Co-authored-by: Benjamin Trenkle <benjamin.trenkle@wicked-software.de>
Co-authored-by: Benjamin Trenkle <bembelimen@users.noreply.github.com>
Co-authored-by: David Jardin <d.jardin@djumla.de>
Co-authored-by: janschoenherr <jan@yootheme.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug NPM Resource Changed This Pull Request can't be tested by Patchtester

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

Comments