Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh the style of alerts #9115

Merged
merged 4 commits into from
Apr 4, 2024
Merged

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Apr 2, 2024

Small pull request to refresh the style of alerts. Some minor tweaks to colours, border radius and weights to bring alerts more inline with the rest of Jenkins.

Before
image

After
image

I'll open a pull request for the dark theme plugin to match.

Testing done

  • Modified the Manage Jenkins screen to display all monitors to test a variety of styles, works as expected

Proposed changelog entries

  • Refresh the style of alerts.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you show all colours please?

success,info,danger,warning.

Even if its just in the browser changing classes


needs a dark theme PR

@janfaracik
Copy link
Contributor Author

Can you show all colours please?

success,info,danger,warning.

Even if its just in the browser changing classes

needs a dark theme PR

Opened a Design Library PR - jenkinsci/design-library-plugin#318 - will update OP

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshots with more detail:

Before image
After image

Main difference is the text is easier to read, looks nice to me

@timja timja added web-ui The PR includes WebUI changes which may need special expertise rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted labels Apr 2, 2024
@timja timja requested a review from a team April 2, 2024 22:02
@janfaracik
Copy link
Contributor Author

Thanks! Appreciate it.

With dark theme:

image

@timja
Copy link
Member

timja commented Apr 3, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 3, 2024
@NotMyFault NotMyFault merged commit b9fac75 into jenkinsci:master Apr 4, 2024
17 checks passed
@mawinter69
Copy link
Contributor

mawinter69 commented Apr 4, 2024

I think this caused a regression for badges on manage Jenkins and other places where badges are used.
image
image
The badges make use of the classes alert-warning, alert-danger and alert-info

@timja timja deleted the reformat-alerts branch April 4, 2024 21:51
@janfaracik
Copy link
Contributor Author

I think this caused a regression for badges on manage Jenkins and other places where badges are used.

image

image

The badges make use of the classes alert-warning, alert-danger and alert-info

Thanks, I'll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants