Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update restart banner to align with updated banners #9191

Merged
merged 2 commits into from
Apr 25, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Apr 24, 2024

Raised as part of the UX Sig today - the restart banner doesn't follow the same style as the updated banners in #9115.

Before
image

After
image

Testing done

  • Banner appears as expected

Proposed changelog entries

  • Update restart banner to align with updated banners.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux @uhafner

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Contributor

@StefanSpieker StefanSpieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice.

@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Apr 24, 2024
@timja
Copy link
Member

timja commented Apr 24, 2024

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Apr 24, 2024
@MarkEWaite MarkEWaite merged commit 22e5886 into jenkinsci:master Apr 25, 2024
17 checks passed
@janfaracik janfaracik deleted the fix-restart-alert branch April 26, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants