Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badge color in dropdowns #9381

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented Jun 12, 2024

Fixes an issue from #9115 + #9155 - badges in dropdowns don't have the correct class, this MR fixes that.

Before
image

After
image

Testing done

  • Badges appear as expected in dropdowns

Proposed changelog entries

  • Fix badge color in dropdowns.

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Jun 12, 2024
@timja timja added the regression-fix Pull request that fixes a regression in one of the previous Jenkins releases label Jun 12, 2024
@MarkEWaite MarkEWaite merged commit 2077112 into jenkinsci:master Jun 13, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback regression-fix Pull request that fixes a regression in one of the previous Jenkins releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants