Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cron Triggers warnings table is not rendered well in administrative warnings #154

Closed
oleg-nenashev opened this issue Jan 20, 2021 · 2 comments
Labels
core-compatibility Dark Theme compatibility issues in the Jenkins core

Comments

@oleg-nenashev
Copy link
Member

SlowTriggerAdminMonitor uses standard types in https://github.com/jenkinsci/jenkins/blob/8c6327f4c6777d135e374e3d507ba9c20820bfc6/core/src/main/resources/hudson/triggers/SlowTriggerAdminMonitor/message.groovy . It leads to a pretyt bad rendering within the warnings pane

image

@oleg-nenashev oleg-nenashev added the core-compatibility Dark Theme compatibility issues in the Jenkins core label Jan 20, 2021
@timja
Copy link
Member

timja commented Jan 20, 2021

the table font colour is set by:
https://github.com/jenkinsci/jenkins/blob/master/war/src/main/less/modules/panes-and-bigtable.less#L19

we could override that in the alerts with something more specific, probably can just go in core rather than here I think

@timja
Copy link
Member

timja commented Jul 13, 2024

Fixed most likely by jenkinsci/jenkins@c37613e or jenkinsci/jenkins#9115:

Tested with:

import hudson.triggers.*

def am = ExtensionList.lookupSingleton(SlowTriggerAdminMonitor.class)

am.report(TimerTrigger.DescriptorImpl.class, "upstream-free", 50000L)
am.report(SCMTrigger.DescriptorImpl.class, "upstream-free", 1000000L)

println am.errors.size()
  
image

@timja timja closed this as completed Jul 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-compatibility Dark Theme compatibility issues in the Jenkins core
Projects
None yet
Development

No branches or pull requests

2 participants