Skip to content

Update Envoy-WASM SHA to latest.#2312

Merged
istio-testing merged 1 commit intoistio:masterfrom
PiotrSikora:envoy_cb251400bd
Jul 19, 2019
Merged

Update Envoy-WASM SHA to latest.#2312
istio-testing merged 1 commit intoistio:masterfrom
PiotrSikora:envoy_cb251400bd

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

@PiotrSikora PiotrSikora commented Jul 17, 2019

Signed-off-by: Piotr Sikora piotrsikora@google.com

@istio-testing istio-testing added the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 17, 2019
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 17, 2019
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 17, 2019
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 17, 2019

Blocked on istio/test-infra#1493 and istio/test-infra#1494 (for Prow) and someone uploading new Docker images (for Linux on CircleCI).

Alternatively, can someone add me to the DockerHub? cc @bianpengyuan @mandarjog

@PiotrSikora PiotrSikora requested a review from bianpengyuan July 17, 2019 03:49
@bianpengyuan
Copy link
Copy Markdown
Contributor

bianpengyuan commented Jul 17, 2019

Circle image pushed.

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 17, 2019

@bianpengyuan thanks!

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 17, 2019

/hold

Please don't merge this until Prow is updated (istio/test-infra#1493, istio/test-infra#1494), otherwise we're going to end up with broken daily builds (tests pass now because we don't run upstream tests, but the binaries are corrupted with Bazel 0.27).

@PiotrSikora PiotrSikora marked this pull request as ready for review July 17, 2019 21:45
@istio-testing istio-testing removed the do-not-merge/work-in-progress Block merging of a PR because it isn't ready yet. label Jul 17, 2019
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 17, 2019

Prow images updated, this should be good to go.

@bianpengyuan
Copy link
Copy Markdown
Contributor

bianpengyuan commented Jul 17, 2019

@silentdai Can you help to approve? Thanks!

@lambdai
Copy link
Copy Markdown
Contributor

lambdai commented Jul 17, 2019

@bianpengyuan
Could you confirm if proxy can survive despite my comment below?
envoyproxy/envoy-wasm@f81e026#r34345829

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 18, 2019

@silentdai good catch, see: envoyproxy/envoy#7623.

@lambdai
Copy link
Copy Markdown
Contributor

lambdai commented Jul 18, 2019

👍 That works :)

@PiotrSikora
Update Envoy-WASM SHA to latest.
494610a 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

PiotrSikora commented Jul 18, 2019

Bumped to include envoyproxy/envoy#7623, @silentdai PTAL.

@lambdai
Copy link
Copy Markdown
Contributor

lambdai commented Jul 19, 2019

/lgtm

Thank you for fixing at upstream!

/approve

@istio-testing
Copy link
Copy Markdown
Collaborator

istio-testing commented Jul 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PiotrSikora, silentdai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@istio-testing istio-testing merged commit 3b68091 into istio:master Jul 19, 2019
PiotrSikora added a commit to PiotrSikora/proxy that referenced this pull request Aug 7, 2019
@PiotrSikora
Fix static linking.
1f4c321 
Broken in istio#2312.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora mentioned this pull request Aug 7, 2019
Merged
PiotrSikora added a commit to PiotrSikora/proxy that referenced this pull request Aug 7, 2019
@PiotrSikora
Fix static linking.
a90853a 
Broken in istio#2312.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
PiotrSikora added a commit to PiotrSikora/proxy that referenced this pull request Aug 7, 2019
@PiotrSikora
Fix static linking.
0797879 
Broken in istio#2312.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
istio-testing pushed a commit that referenced this pull request Aug 7, 2019
@PiotrSikora @istio-testing
Fix static linking. (#2342)
9e5640a 
* Fix static linking.

Broken in #2312.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>

* Fix initialization-order-fiasco.

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rshriram rshriram Awaiting requested review from rshriram

@lambdai lambdai Awaiting requested review from lambdai

@bianpengyuan bianpengyuan Awaiting requested review from bianpengyuan

Assignees

@lambdai lambdai

Labels

cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@PiotrSikora @bianpengyuan @lambdai @istio-testing @googlebot