release: un-deprecate "use_original_dst".#7623
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Jul 18, 2019
Merged
release: un-deprecate "use_original_dst".#7623mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
"use_original_dst" and "bind_to_port" are two complementary parts of the "virtual listeners" feature, and they should be deprecated together. However, they are both currently exempted (see: envoyproxy#5355), so revert the change from envoyproxy#7549. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Contributor
Author
|
cc @alyssawilk @mattklein123 @silentdai |
Member
|
Actually, @PiotrSikora should we just undeprecate this in the config also to avoid the warning? /wait-any |
Contributor
Author
|
@mattklein123 both fields are deprecated in the config one way ( Also, @silentdai is actively working on migrating Istio to filter chains, so we shouldn't need anymore it in 4-6 weeks, and then we can add them both to this list. |
Member
|
OK sounds good. |
TAOXUY
pushed a commit
to TAOXUY/envoy
that referenced
this pull request
Jul 22, 2019
"use_original_dst" and "bind_to_port" are two complementary parts of the "virtual listeners" feature, and they should be deprecated together. However, they are both currently exempted (see: envoyproxy#5355), so revert the change from envoyproxy#7549. Signed-off-by: Piotr Sikora <piotrsikora@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"use_original_dst" and "bind_to_port" are two complementary parts
of the "virtual listeners" feature, and they should be deprecated
together.
However, they are both currently exempted (see: #5355), so revert
the change from #7549.
Signed-off-by: Piotr Sikora piotrsikora@google.com